Skip to content

feat: Modify end time of lambda load span to be last cold start node … #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Mar 28, 2023

…end time instead of start time of function.

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner March 28, 2023 19:47
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #372 (4c4891d) into main (35295b3) will increase coverage by 0.24%.
The diff coverage is 75.94%.

❗ Current head 4c4891d differs from pull request most recent head f0e253a. Consider uploading reports for the commit f0e253a to get more accurate results

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   80.35%   80.59%   +0.24%     
==========================================
  Files          36       38       +2     
  Lines        1761     1902     +141     
  Branches      410      439      +29     
==========================================
+ Hits         1415     1533     +118     
- Misses        294      312      +18     
- Partials       52       57       +5     
Impacted Files Coverage Δ
src/runtime/user-function.ts 7.69% <ø> (+7.69%) ⬆️
src/trace/listener.ts 64.70% <30.00%> (-3.48%) ⬇️
src/trace/context.ts 80.00% <57.89%> (-8.18%) ⬇️
src/trace/cold-start-tracer.ts 85.71% <85.71%> (ø)
src/runtime/require-tracer.ts 96.96% <96.96%> (ø)
src/index.ts 87.59% <100.00%> (+1.04%) ⬆️
src/runtime/index.ts 100.00% <100.00%> (+100.00%) ⬆️
src/trace/span-inferrer.ts 89.34% <100.00%> (+0.10%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

…rent span, or the end of the last cold start node
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astuyve astuyve merged commit f03601b into main Mar 30, 2023
@astuyve astuyve deleted the aj/end-load-span-after-last-module branch March 30, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants