Fix arg info #37
Closed
Fix arg info #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a debug build of PHP, the engine verifies that the info supplied in the `ZEND_BEGIN_ARG_INFO_EX` macro is correct. The last parameter of the `ZEND_BEGIN_ARG_INFO_EX` macro is the number of required arguments. If we try to invoke `ibase_commit` with zero arguments, we get the following error message: ``` Fatal error: Arginfo / zpp mismatch during call of ibase_commit() in test.php on line 123 ``` This patch corrects this by setting the value to zero to match how the method is implemented.
When running a debug build of PHP, the engine verifies that the info supplied in the `ZEND_BEGIN_ARG_INFO_EX` macro is correct. The last parameter of the `ZEND_BEGIN_ARG_INFO_EX` macro is the number of required arguments. If we try to invoke `ibase_rollback` with zero arguments, we get the following error message: ``` Fatal error: Arginfo / zpp mismatch during call of ibase_rollback() in test.php on line 123 ``` This patch corrects this by setting the value to zero to match how the method is implemented.
When running a debug build of PHP, the engine verifies that the info supplied in the `ZEND_BEGIN_ARG_INFO_EX` macro is correct. The last parameter of the `ZEND_BEGIN_ARG_INFO_EX` macro is the number of required arguments. If we try to invoke `ibase_commit_ret` with zero arguments, we get the following error message: ``` Fatal error: Arginfo / zpp mismatch during call of ibase_commit_ret() in test.php on line 123 ``` This patch corrects this by setting the value to zero to match how the method is implemented.
When running a debug build of PHP, the engine verifies that the info supplied in the `ZEND_BEGIN_ARG_INFO_EX` macro is correct. The last parameter of the `ZEND_BEGIN_ARG_INFO_EX` macro is the number of required arguments. If we try to invoke `ibase_rollback_ret` with zero arguments, we get the following error message: ``` Fatal error: Arginfo / zpp mismatch during call of ibase_rollback_ret() in test.php on line 123 ``` This patch corrects this by setting the value to zero to match how the method is implemented.
|
Closing. This was folded into #39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a debug build of PHP, the engine verifies that the info supplied in the
ZEND_BEGIN_ARG_INFO_EXmacro is correct. The last parameter of theZEND_BEGIN_ARG_INFO_EXmacro is the number of required arguments.For example, if we try to invoke
ibase_commitwith zero arguments, we get the following error message:This PR fixes this problem for
ibase_commit,ibase_commit_ret,ibase_rollback, andibase_rollback_ret.