Skip to content

Add SaveFindingsToGcs output proto conversion sample for DLP #10137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrickmoy
Copy link
Member

Description

Fixes: N/A
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@patrickmoy patrickmoy requested review from yoshi-approver and a team as code owners July 23, 2025 13:01
Copy link

snippet-bot bot commented Jul 23, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dlp Issues related to the Sensitive Data Protection API. labels Jul 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @patrickmoy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new sample for Google Cloud DLP, specifically demonstrating how to process and parse findings that have been saved to Google Cloud Storage in a protobuf text format. This sample provides a practical example for developers to convert the SaveToGcsFindingsOutput proto into a usable format, enabling them to extract and analyze individual DLP findings. It also includes necessary dependency updates and a corresponding test case.

Highlights

  • New DLP Sample: I've added a new Java sample, ProcessInspectFindingsSavedToGcs.java, which demonstrates how to process and parse DLP findings that have been saved to Google Cloud Storage in a protobuf text format. This sample reads a local file containing the proto output and extracts individual Finding details.
  • Dependency Updates: To support the new sample's functionality, I've updated the google-cloud Bill of Materials (BOM) version in pom.xml and explicitly added the protobuf-java dependency, which is essential for parsing protobuf messages.
  • New Test Case and Sample Data: A new test method, testProcessInspectFindingsSavedToGcs, has been added to InspectTests.java to validate the correctness of the new sample. This test utilizes a new resource file, save_to_gcs_findings.txt, which contains a representative sample of DLP findings in protobuf text format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Java sample for DLP, demonstrating how to parse findings that have been saved to a file from a GCS inspection job. The implementation is straightforward and a corresponding test is included. My review focuses on improving correctness, maintainability, and code clarity in the new sample file. I've identified a critical resource leak and suggested a fix that also improves memory efficiency. Other recommendations include removing unused code and imports, clarifying a Javadoc comment, and updating the copyright header to be more precise. These changes will make the sample more robust and easier to understand.

@patrickmoy patrickmoy force-pushed the main branch 2 times, most recently from e78bf49 to 5146cb1 Compare July 23, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants