Add package exports for browser and umd

[gjvoosten]

PR description

Add package exports for browser and umd

Fixes #145

Checklist

• - Added tests
• - Ran npm test, ensuring linting passes
• - Adjust README documentation if relevant

[brettz9]

Thanks for your reporting this. A few tweaks, and then I'd need someone to vouch that the browser issue is importing as expected.

[brettz9]

Please keep this. It helps make explicit how the behavior works. See https://nodejs.org/api/packages.html for the standard that webpack and Rollup plugins are or ought to be (and likely will be if they aren't already) following.

[gjvoosten]

Please keep this. It helps make explicit how the behavior works. See https://nodejs.org/api/packages.html for the standard that webpack and Rollup plugins are or ought to be (and likely will be if they aren't already) following.

Sorry, but with "type": "commonjs" babel/webpack tell me:

ERROR in ./node_modules/jsonpath-plus/dist/index-browser-esm.js 1061:0
Module parse failed: 'import' and 'export' may appear only with 'sourceType: module' (1061:0)

[brettz9]

Hmm... I've added a comment at webpack/webpack#11597 (comment) , as it looks to me that bundlers should not be using type for interpretation of non-Node fields. There is a workaround there that may work for now without our changing the code, as I really think we should be able to use ".js" with browser ESM while using type: commonjs for Node. If we don't hear back in some time, let's file a new Webpack issue.

[brettz9]

And when revisiting this, Node recommends using default over browser (that probably makes sense too since other environments might support our own "vm" but not Node's).

[gjvoosten]

There is a workaround there that may work for now without our changing the code

If by that work-around you mean adding something like:

  module: {
    rules: [
      {
        test: /browser-esm\.js$/,
        include: /node_modules\/jsonpath-plus/,
        type: "javascript/auto"
      },
      …
    ]
  }

to my webpack config, then: no, that doesn't work. Webpack 5 still loads the node version.

[brettz9]

I went ahead and filed webpack/webpack#12598 as I do recall you had this before. Will see about a response.

[brettz9]

Given our earlier discussion of this, I wanted to let you know (and anyone watching this) that I am planning to release as a true ESM module by using type: 'module' (otherwise our default ".js" is not understood in some environments as being a genuine module, e.g., Mocha 9 fails completely, and I think it has only been working in modules up to now because ESM can import CJS as we provide).

Would you mind testing out the esm branch?

[gjvoosten]

@brettz9 Where do I find this esm branch?

[brettz9]

Oh, sorry, https://github.com/brettz9/JSONPath/tree/esm , i.e., cloning https://github.com/brettz9/JSONPath#esm

[gjvoosten]

@brettz9 Appears to work fine; apologies for the delay.