Skip to content

Extension property name generation fix & docs & tests #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025

Conversation

AndreiKingsley
Copy link
Collaborator

Fixes #1193

df.`size in inches`
```

However, sometimes the original column name contains special symbols
Copy link
Collaborator

@koperagen koperagen Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence is not clear to me, sorry. Why there's "and can still.."? Because these two parts don't seem to be very connected

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, there should be simply "can't" 😃

@AndreiKingsley AndreiKingsley merged commit 9927dbf into master Aug 15, 2025
3 of 4 checks passed
@AndreiKingsley AndreiKingsley deleted the extension_property_name_fix branch August 15, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with line break in column name props generation + align renameToCamelCase and normalization behavior
3 participants