fix: ensure ChatCompletionChunk delta is always ChoiceDelta in final … #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Azure streaming chunk ### Description Fixes issue openai#1677 where the final streaming chunk for `ChatCompletionChunk` from Azure OpenAI returns `delta` as `None`. This causes issues in typed clients expecting a `ChoiceDelta`. ### Changes - Default `delta` to an empty `ChoiceDelta` when missing in the final chunk. - Ensures consistent typing for all streamed chunks. ### Why? Clients consuming the stream expect `delta` to always be a valid `ChoiceDelta`. This change prevents `NoneType` errors and maintains consistent response structure. Closes openai#1677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Azure streaming chunk
Description
Fixes issue openai#1677 where the final streaming chunk for
ChatCompletionChunkfrom Azure OpenAI returnsdeltaasNone. This causes issues in typed clients expecting aChoiceDelta.Changes
deltato an emptyChoiceDeltawhen missing in the final chunk.Why?
Clients consuming the stream expect
deltato always be a validChoiceDelta. This change preventsNoneTypeerrors and maintains consistent response structure.Closes openai#1677
Changes being requested
Additional context & links