Fix: Default tool_choice to "auto" for GPT-5 models to prevent API er… #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors Fix server error for GPT-5 models when using unsupported tool_choice values Some GPT-5 models currently only support `tool_choice="auto"`. Sending other values (e.g., "required" or specific tool names) results in a 400 error: "Tool choices other than 'auto' are not supported with model". This patch updates `threads.py` to automatically coerce unsupported `tool_choice` values to `"auto"` for GPT-5 models, preventing the error and ensuring consistent behavior. Changes: - Added conditional check for GPT-5 model IDs. - Coerce or remove unsupported tool_choice values before sending the request. - Added warning log when coercion occurs. This preserves backwards compatibility for other models and avoids runtime failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rors
Fix server error for GPT-5 models when using unsupported tool_choice values
Some GPT-5 models currently only support
tool_choice="auto". Sending other values (e.g., "required" or specific tool names) results in a 400 error: "Tool choices other than 'auto' are not supported with model".This patch updates
threads.pyto automatically coerce unsupportedtool_choicevalues to"auto"for GPT-5 models, preventing the error and ensuring consistent behavior.Changes:
This preserves backwards compatibility for other models and avoids runtime failures.
Changes being requested
Additional context & links