Make file types consistent between grammars/ and package.json #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This made .pyi, .gyp, and .gypi available in all editors. I put comments there to help others find the other file in the future. Would be nicer still to automate this but I frankly don't have cycles for that now. Test plan: ran `make test`, passed. Installed this package locally with `apm link`, confirm new file types are visible.
|
Thanks, Lukasz! I'll make a release right now (enjoy f-strings!) |
|
If you can hold on, I have a few other things in mind :-) |
|
Go ahead :) |
|
Also, I didn't add wsgi files here so #66 should be reopened. |
|
.wsgi file extension is still missing |
|
@luca76 Rebase your diff and make sure to add the extension in both places. Yury will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made .pyi, .gyp, and .gypi available in all editors. I put comments there
to help others find the other file in the future. Would be nicer still to
automate this but I frankly don't have cycles for that now.
Test plan: ran
make test, passed. Installed this package locally withapm link, confirm new file types are visible.