Add support to specify pre-resolved IP addresses and avoid additional DNS lookup #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to support this PR MaterializeInc/materialize#26186 by allowing us to specify multiple pre-resolved IP addresses to avoid a DNS lookup inside the library.
I wanted to know what you thought of the API changes before opening the upstream PR. Since we recently also added support for an explicit TLS hostname override https://docs.rs/mysql_async/latest/mysql_async/struct.SslOpts.html#method.with_danger_tls_hostname_override it seems a bit clunky to keep the
hostname
field on the newHostPortOrUrl::ResolvedHost
enum type I introduced, but without that field it's unclear what we should return fromget_ip_or_hostname
, which is behind a public method returning a&str