PHP 8.4 | Tokenizer/PHP: fix union/intersection/DNF type tokenization with abstract properties #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with abstract properties This commit adds support for `abstract` properties to the PHP Tokenizer as otherwise the retokenization of `|` to `T_TYPE_UNION`, `&` to `T_TYPE_INTERSECTION` and the parenthesis in DNF types to `T_TYPE_*_PARENTHESIS` would be broken. Fixed now. Includes tests. Includes some extra tests for the `T_NULLABLE` tokenization as well, just to be on the safe side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds support for
abstractproperties to the PHP Tokenizer as otherwise the retokenization of|toT_TYPE_UNION,&toT_TYPE_INTERSECTIONand the parenthesis in DNF types toT_TYPE_*_PARENTHESISwould be broken.Fixed now.
Includes tests.
Includes some extra tests for the
T_NULLABLEtokenization as well, just to be on the safe side.Suggested changelog entry
abstractproperties in the Tokenizer.Related issues/external references
Related to #734