Take Bug fixes to Master #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8919af7.
When importing customized rules, we take Ast type instead of name to apply rules. Modify string comparsion Add check for null diagnosticRecord returned.
Also added try/catch to capture errors in customized rule modules and throw non-terminating errors
Also added parameterType to external rule to separate parameter type and parameter name
Fix bugs in importing external rule
Suppress write host for function that starts with show
… script - new WMI cmdlets covered
… script - new WMI cmdlets covered
Avoid using wmi cmdlet rule
…etBinding attribute specified.
Only Trigger PSProvideVerboseMessage in Advanced Scripts or Functions
Revert "Only Trigger PSProvideVerboseMessage in Advanced Scripts or F…
Revert "Revert "Only Trigger PSProvideVerboseMessage in Advanced Scri…
Added quotes for code
…onBranch Avoid wmi cmdlet rule documentation
…100-BugFixes Revert the pull request
|
Looks good to me. |
|
Looks good to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are preparing to release a new version to the gallery from Master