Fix bugs from bugbash #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close this pull request to fix another bug. Will reopen later |
|
Reopen with a bug fix to raise error when Rule Suppression ID does not match. |
|
Looks good to me. |
|
pls merge |
|
I added another commit to add RuleSuppressionIDs for the rules that we discussed. Also improve the error message outputted. Please check them. Thanks. |
|
Looks good. |
|
Thanks. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Null Constructor
• Target wildcard support
• Throw errors if any suppression is not found (wrong target name)
• Suppression still works when positional parameter comes first
• If scope is wrong, should throw error instead of running suppression
• Numbers in rule positional parameter results in invoke throwing a terminating error
• Suppress scope issue (if you provide the wrong scope in the suppression within a function, eg. Scope="class" to a function, it suppressed the class but not the function)
Currently, still not throwing error for wrong RuleSuppressionID