Add an aiomqtt based MQTT session module #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenporter
force-pushed
the
async-mqtt-session
branch
from
405832c to
9ccb258
Compare
|
Looks like the tests fail when run from CI. Taking a look. |
allenporter
force-pushed
the
async-mqtt-session
branch
from
37a76ae to
aab46ae
Compare
allenporter
force-pushed
the
async-mqtt-session
branch
from
aab46ae to
22b9a3f
Compare
allenporter
force-pushed
the
async-mqtt-session
branch
from
cb33def to
0cf621f
Compare
Lash-L
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an aiomqtt based MQTT session module. This is based on #364 with some additional unit tests and support for retries.
The session is created by invoking
create_mqtt_session. A caller may subscribe to a topic, and the session keeps track of which callbacks to invoke for each topic. The client is run as a background task that will run until shutdown. Once connected, the client will wait for messages to be received in a loop. If the connection is lost, the client will be re-created and reconnected. There is backoff to avoid spamming the broker with connection attempts. The clientwill automatically re-establish any subscriptions when the connection is re-established.
It is very difficult to exercise the failure cases with aiomqtt, so these will need to be exercised manually. This does not contain any roborock specific information.