Update tests to improve CI logging to better diagnose timeout #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks to still flake unfortunately Any easy way in purest to just retry? Retry each test twice or something? I get that that wouldn't be perfect either though |
allenporter
changed the title
|
I reverted removing the tests and added explicit shutdown calls at the end of each test. I also turned up logging on CI with thread names and timestamps. Funnily, its not timing out as often now, not sure if its because logging triggers I/O which causes the race to behave differently or something else. |
Lash-L
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tests that often timeout on CI. This will result in lower test coverage, but probably not worth it given the flakes.