feat: Support both a01 and v1 device types with traits #425
Conversation
| def traits(self) -> Mapping[str, Trait]: | ||
| """Return the traits of the device.""" | ||
| return MappingProxyType(self._trait_map) |
There was a problem hiding this comment.
Why can't this just stay as a dict as is? I don't really know what MappingProxyType is
There was a problem hiding this comment.
When this returns a dict its actually mutable so a caller could theoretically change it. It may be overkill here...
allenporter
force-pushed
the
device-traits
branch
from
80358bd to
384e249
Compare
allenporter
force-pushed
the
device-traits
branch
from
95ebf54 to
ba06e49
Compare
| self._product_info = product_info | ||
| self._rpc_channel = rpc_channel | ||
|
|
||
| async def get_status(self) -> Status: |
There was a problem hiding this comment.
So does each trait have its own unique functions? This may negate the need for the traits property, as iterating through them wouldn't be helpful as you need to do different things Per trait
There was a problem hiding this comment.
although I guess the traits() property just gives a mapping, so you can still do everything specifically there as well.
There was a problem hiding this comment.
My assumption is traits will have multiple functions of related properties. However, maybe that is not the case, so i take your point that if every trait really is one thing then its just a grab bag of functions?
There was a problem hiding this comment.
Maybe i take your point as traits can be flattened properties on the device, which i agree with. I was assuming we'd go to something like this:
if device.status:
print(await device.status.get_status())
There was a problem hiding this comment.
Most of the time they come down to two things:
Get the latest version of myself
change myself or perform an action
sometimes there are multiple different ways you can make changes, but typically, there is just one way to update data and every single trait would need to have that.
I don't think there is a problem with:
tasks = [] if self.status: tasks.append(self.status.get_status())
but we will just have a long set of code opposed to:
await asyncio.gather(*trait.update() for trait in self.traits)
No description provided.