3.x: Remove now unnecessary unchecked warning suppressions

src/jmh/java/io/reactivex/rxjava3/core/MemoryPerf.java

@@ -184,7 +184,7 @@ public Object call() throws Exception {
         checkMemory(new Callable<Object>() {
             @Override
             public Object call() throws Exception {
-                return new io.reactivex.rxjava3.observers.TestObserver<Object>();
+                return new io.reactivex.rxjava3.observers.TestObserver<>();
             }
         }, "test-consumer", "Rx2Observable");
 
@@ -374,7 +374,7 @@ public Object call() throws Exception {
         checkMemory(new Callable<Object>() {
             @Override
             public Object call() throws Exception {
-                return new io.reactivex.rxjava3.observers.TestObserver<Object>();
+                return new io.reactivex.rxjava3.observers.TestObserver<>();
             }
         }, "test-consumer", "Rx2Flowable");
 

src/jmh/java/io/reactivex/rxjava3/core/OperatorMergePerf.java

@@ -134,7 +134,7 @@ public static class InputForMergeN {
         @Setup
         public void setup(final Blackhole bh) {
             this.bh = bh;
-            observables = new ArrayList<Flowable<Integer>>();
+            observables = new ArrayList<>();
             for (int i = 0; i < size; i++) {
                 observables.add(Flowable.just(i));
             }

src/test/java/io/reactivex/rxjava3/flowable/FlowableCollectTest.java

@@ -167,7 +167,6 @@ public void accept(Object o, Integer t) {
         assertFalse(added.get());
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void collectIntoFlowable() {
         Flowable.just(1, 1, 1, 1, 2)
@@ -316,7 +315,6 @@ public void accept(Object o, Integer t) {
         assertFalse(added.get());
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void collectInto() {
         Flowable.just(1, 1, 1, 1, 2)

src/test/java/io/reactivex/rxjava3/flowable/FlowableConcatTests.java

@@ -61,7 +61,6 @@ public void concatWithIterableOfFlowable() {
         Flowable<String> f2 = Flowable.just("three", "four");
         Flowable<String> f3 = Flowable.just("five", "six");
 
-        @SuppressWarnings("unchecked")
         Iterable<Flowable<String>> is = Arrays.asList(f1, f2, f3);
 
         List<String> values = Flowable.concat(Flowable.fromIterable(is)).toList().blockingGet();

src/test/java/io/reactivex/rxjava3/flowable/FlowableNullTests.java

@@ -47,7 +47,6 @@ public void ambVarargsNull() {
         Flowable.ambArray((Publisher<Object>[])null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void ambVarargsOneIsNull() {
         Flowable.ambArray(Flowable.never(), null).blockingLast();
@@ -68,7 +67,6 @@ public Iterator<Publisher<Object>> iterator() {
         }).test().assertError(NullPointerException.class);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambIterableOneIsNull() {
         Flowable.amb(Arrays.asList(Flowable.never(), null))
@@ -101,7 +99,6 @@ public Object apply(Object[] v) {
         }).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void combineLatestIterableOneIsNull() {
         Flowable.combineLatestDelayError(Arrays.asList(Flowable.never(), null), new Function<Object[], Object>() {
@@ -112,13 +109,11 @@ public Object apply(Object[] v) {
         }).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void combineLatestIterableFunctionNull() {
         Flowable.combineLatestDelayError(Arrays.asList(just1), null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void combineLatestIterableFunctionReturnsNull() {
         Flowable.combineLatestDelayError(Arrays.asList(just1), new Function<Object[], Object>() {
@@ -144,7 +139,6 @@ public Iterator<Publisher<Object>> iterator() {
         }).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void concatIterableOneIsNull() {
         Flowable.concat(Arrays.asList(just1, null)).blockingLast();
@@ -161,7 +155,6 @@ public void concatArrayNull() {
         Flowable.concatArray((Publisher<Object>[])null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void concatArrayOneIsNull() {
         Flowable.concatArray(just1, null).blockingLast();
@@ -480,7 +473,6 @@ public Iterator<Publisher<Object>> iterator() {
         }, 128, 128).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void mergeIterableOneIsNull() {
         Flowable.merge(Arrays.asList(just1, null), 128, 128).blockingLast();
@@ -512,7 +504,6 @@ public Iterator<Publisher<Object>> iterator() {
         }, 128, 128).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void mergeDelayErrorIterableOneIsNull() {
         Flowable.mergeDelayError(Arrays.asList(just1, null), 128, 128).blockingLast();
@@ -634,13 +625,11 @@ public Object apply(Object[] v) {
         }).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void zipIterableFunctionNull() {
         Flowable.zip(Arrays.asList(just1, just1), null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void zipIterableFunctionReturnsNull() {
         Flowable.zip(Arrays.asList(just1, just1), new Function<Object[], Object>() {
@@ -676,13 +665,11 @@ public Object apply(Object[] a) {
         }, true, 128).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void zipIterable2FunctionNull() {
         Flowable.zip(Arrays.asList(just1, just1), null, true, 128);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void zipIterable2FunctionReturnsNull() {
         Flowable.zip(Arrays.asList(just1, just1), new Function<Object[], Object>() {
@@ -2679,7 +2666,6 @@ public void unsafeSubscribeNull() {
         just1.subscribe((FlowableSubscriber<Object>)null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void combineLatestDelayErrorIterableFunctionReturnsNull() {
         Flowable.combineLatestDelayError(Arrays.asList(just1), new Function<Object[], Object>() {
@@ -2690,7 +2676,6 @@ public Object apply(Object[] v) {
         }, 128).blockingLast();
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void combineLatestDelayErrorIterableFunctionNull() {
         Flowable.combineLatestDelayError(Arrays.asList(just1), null, 128);
@@ -2731,7 +2716,6 @@ public void doOnDisposeNull() {
         just1.doOnCancel(null);
     }
 
-    @SuppressWarnings("unchecked")
     @Test(expected = NullPointerException.class)
     public void combineLatestDelayErrorIterableOneIsNull() {
         Flowable.combineLatestDelayError(Arrays.asList(Flowable.never(), null), new Function<Object[], Object>() {

src/test/java/io/reactivex/rxjava3/flowable/FlowableTests.java

@@ -1074,7 +1074,6 @@ public void toObservableError() {
 
     @Test
     public void zipIterableObject() {
-        @SuppressWarnings("unchecked")
         final List<Flowable<Integer>> flowables = Arrays.asList(Flowable.just(1, 2, 3), Flowable.just(1, 2, 3));
         Flowable.zip(flowables, new Function<Object[], Object>() {
             @Override
@@ -1090,7 +1089,6 @@ public Object apply(Object[] o) throws Exception {
 
     @Test
     public void combineLatestObject() {
-        @SuppressWarnings("unchecked")
         final List<Flowable<Integer>> flowables = Arrays.asList(Flowable.just(1, 2, 3), Flowable.just(1, 2, 3));
         Flowable.combineLatest(flowables, new Function<Object[], Object>() {
             @Override

src/test/java/io/reactivex/rxjava3/internal/operators/completable/CompletableMaterializeTest.java

@@ -24,7 +24,6 @@
 public class CompletableMaterializeTest extends RxJavaTest {
 
     @Test
-    @SuppressWarnings("unchecked")
     public void error() {
         TestException ex = new TestException();
         Completable.error(ex)
@@ -34,7 +33,6 @@ public void error() {
     }
 
     @Test
-    @SuppressWarnings("unchecked")
     public void empty() {
         Completable.complete()
         .materialize()

src/test/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableAmbTest.java

@@ -102,7 +102,6 @@ public void amb() {
         Flowable<String> flowable3 = createFlowable(new String[] {
                 "3", "33", "333", "3333" }, 3000, null);
 
-        @SuppressWarnings("unchecked")
         Flowable<String> f = Flowable.ambArray(flowable1,
                 flowable2, flowable3);
 
@@ -131,7 +130,6 @@ public void amb2() {
         Flowable<String> flowable3 = createFlowable(new String[] {},
                 3000, new IOException("fake exception"));
 
-        @SuppressWarnings("unchecked")
         Flowable<String> f = Flowable.ambArray(flowable1,
                 flowable2, flowable3);
 
@@ -158,7 +156,6 @@ public void amb3() {
         Flowable<String> flowable3 = createFlowable(new String[] {
                 "3" }, 3000, null);
 
-        @SuppressWarnings("unchecked")
         Flowable<String> f = Flowable.ambArray(flowable1,
                 flowable2, flowable3);
 
@@ -171,7 +168,6 @@ public void amb3() {
         inOrder.verifyNoMoreInteractions();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void producerRequestThroughAmb() {
         TestSubscriber<Integer> ts = new TestSubscriber<>(0L);
@@ -237,7 +233,6 @@ public void backpressure() {
         assertEquals(Flowable.bufferSize() * 2, ts.values().size());
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void subscriptionOnlyHappensOnce() throws InterruptedException {
         final AtomicLong count = new AtomicLong();
@@ -262,7 +257,6 @@ public void accept(Subscription s) {
         assertEquals(2, count.get());
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void secondaryRequestsPropagatedToChildren() throws InterruptedException {
         //this aync stream should emit first
@@ -302,7 +296,6 @@ public void accept(Integer t) {
         assertEquals(1, result);
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambCancelsOthers() {
         PublishProcessor<Integer> source1 = PublishProcessor.create();
@@ -347,7 +340,6 @@ public void multipleUse() {
         ts2.assertNoErrors();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambIterable() {
         PublishProcessor<Integer> pp1 = PublishProcessor.create();
@@ -370,7 +362,6 @@ public void ambIterable() {
         ts.assertComplete();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambIterable2() {
         PublishProcessor<Integer> pp1 = PublishProcessor.create();
@@ -393,19 +384,16 @@ public void ambIterable2() {
         ts.assertComplete();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambArrayEmpty() {
         assertSame(Flowable.empty(), Flowable.ambArray());
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambArraySingleElement() {
         assertSame(Flowable.never(), Flowable.ambArray(Flowable.never()));
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void disposed() {
         TestHelper.checkDisposed(Flowable.ambArray(Flowable.never(), Flowable.never()));
@@ -442,7 +430,6 @@ public void onNextRace() {
             final PublishProcessor<Integer> pp1 = PublishProcessor.create();
             final PublishProcessor<Integer> pp2 = PublishProcessor.create();
 
-            @SuppressWarnings("unchecked")
             TestSubscriberEx<Integer> ts = Flowable.ambArray(pp1, pp2).to(TestHelper.<Integer>testConsumer());
 
             Runnable r1 = new Runnable() {
@@ -471,7 +458,6 @@ public void onCompleteRace() {
             final PublishProcessor<Integer> pp1 = PublishProcessor.create();
             final PublishProcessor<Integer> pp2 = PublishProcessor.create();
 
-            @SuppressWarnings("unchecked")
             TestSubscriber<Integer> ts = Flowable.ambArray(pp1, pp2).test();
 
             Runnable r1 = new Runnable() {
@@ -499,7 +485,6 @@ public void onErrorRace() {
             final PublishProcessor<Integer> pp1 = PublishProcessor.create();
             final PublishProcessor<Integer> pp2 = PublishProcessor.create();
 
-            @SuppressWarnings("unchecked")
             TestSubscriber<Integer> ts = Flowable.ambArray(pp1, pp2).test();
 
             final Throwable ex = new TestException();
@@ -531,7 +516,6 @@ public void run() {
         }
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void nullIterableElement() {
         Flowable.amb(Arrays.asList(Flowable.never(), null, Flowable.never()))
@@ -575,21 +559,18 @@ public void ambWithOrder() {
         Flowable.just(1).ambWith(error).test().assertValue(1).assertComplete();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambIterableOrder() {
         Flowable<Integer> error = Flowable.error(new RuntimeException());
         Flowable.amb(Arrays.asList(Flowable.just(1), error)).test().assertValue(1).assertComplete();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void ambArrayOrder() {
         Flowable<Integer> error = Flowable.error(new RuntimeException());
         Flowable.ambArray(Flowable.just(1), error).test().assertValue(1).assertComplete();
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void noWinnerSuccessDispose() throws Exception {
         for (int i = 0; i < TestHelper.RACE_LONG_LOOPS; i++) {
@@ -615,7 +596,6 @@ public void accept(Object v) throws Exception {
         }
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void noWinnerErrorDispose() throws Exception {
         final TestException ex = new TestException();
@@ -642,7 +622,6 @@ public void accept(Throwable e) throws Exception {
         }
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void noWinnerCompleteDispose() throws Exception {
         for (int i = 0; i < TestHelper.RACE_LONG_LOOPS; i++) {
@@ -668,7 +647,6 @@ public void run() throws Exception {
         }
     }
 
-    @SuppressWarnings("unchecked")
     @Test
     public void publishersInIterable() {
         Publisher<Integer> source = new Publisher<Integer>() {