https://docs.rs/rsa/latest/rsa/struct.RsaPrivateKey.html#method.precompute is public

[wez]

While looking at perf, I noticed this precompute method: https://docs.rs/rsa/latest/rsa/struct.RsaPrivateKey.html#method.precompute

In #23 (comment) it mentions that this should be private and that it is implicitly called during construction.

That issue was closed, but it seems like this still needs to be resolved

[tarcieri]

Yeah, it should be removed from the public API. We can at least deprecate it.

[complexspaces]

I believe that the method should remain public so that users of the PrivateKeyParts trait can know when the different pre-computed values have been prepared (see this Zulip conversation as well). Without it, there's no other guarantees that a instance of RsaPrivateKey has these values available internally since its primarily just an implementation detail. We specifically need it to support "exporting" into a JWK format, which requires all of the additional values.

[newpavlov]

I think we can close this issue? Exposing the method does not cause any issues.

[tarcieri]

I believe that the method should remain public so that users of the PrivateKeyParts trait can know when the different pre-computed values have been prepared

Or alternatively, these methods can internally call precompute() to ensure that PrecomputedValues have been populated. That would avoid the need to call it yourself, and potentially allow the accessor methods to be infallible.