Incorrect URL generated when creating fulfillment records - API version 2023-01

[iCodeTechnologies]

Issue summary

When calling shopify.Fulfillment.create the resulting URL is incorrect preventing the successful creation of the Fulfillment record.

Expected behavior

The URL generated by the Shopify client library should be

/admin/api/<API_VERSION>/fulfillments.json

Actual behavior

The URL generated by the Shopify client library is

/admin/api/<API_VERSION>/orders//fulfillments.json

NOTE: The call to shopify.Fulfillment.create does not accept an order_id parameter.

Steps to reproduce the problem

1. Create Shopify session with api_version set to '2023-01'
2. Call shopify.Fulfillment.create with a valid fulfillment payload

Reduced test case

import logging
import shopify

logging.basicConfig(level=logging.DEBUG)

shop_uri = 'xxx.myshopify.com'
api_version = '2023-01'
access_token = 'shppa_xxx'

session = shopify.Session(shop_uri, api_version, access_token)
shopify.ShopifyResource.activate_session(session)

payload = dict(
    line_items_by_fulfillment_order=[dict(fulfillment_order_id="5894084460693", fulfillment_order_line_items=[
        dict(id="12190922277013", quantity="1")])])

shopify.Fulfillment.create(payload)

The best way to get your bug fixed is to provide a reduced test case.

---

Checklist

• I have described this issue in a way that is actionable (if possible)

[iCodeTechnologies]

Looking in the code I can see that the Order resource implements a function called _prefix that appears to allow for the URL to contain a path element "/customers" if a customer_id is included in the options, or omit the "/customers" path element if no customer_id is present.

class Order(ShopifyResource, mixins.Metafields, mixins.Events):
    _prefix_source = "/customers/$customer_id/"

    @classmethod
    def _prefix(cls, options={}):
        customer_id = options.get("customer_id")
        if customer_id:
            return "%s/customers/%s" % (cls.site, customer_id)
        else:
            return cls.site

would this approach work for the Fulfillment resource?

[MohamedAliHamza]

Hi @iCodeTechnologies, I have the same issue too, but the generated URL from lib is
/admin/api/<API_VERSION>/orders/<order_id>/fulfillments.json
NOT /admin/api/<API_VERSION>/orders//fulfillments.json
so that we're getting a ResourceNotFound error

I was using Shopify version 2022-04 and it works fine but after upgrading to the last version which is 2023-01 and the lib to 12.2.0 I'm getting that error.

Based on this release this endpoint has been removed and we're supposed to consume the alternative one.

[xavierpeich]

I'm having trouble updating my fulfillment python script now that we are supposed to migrate to the new API. I was using shopify.Fulfillment() before. My understanding is that we should now use something like shopify.FulfillmentOrder() instead, but this method is not available yet in this library? Not sure what to do.

[hubertlepicki]

So I have just stumbled upon this, and I found a temporary fix, by monkey-patching the prefix on the Fulfillment resource:

shopify.Fulfillment._prefix_source = ''

Added this on top of my script after import shopify and creating fulfillments for fullfillment_orders work.

Having said that, I know nothing about Python and very little about Shopify api so please do correct me if that's some herecy. I used to be Ruby developer. Be kind to me please. ;)

[bjquinn]

shopify.Fulfillment._prefix_source = ''

@hubertlepicki Thank you, this worked for me. The patch proposed by @iCodeTechnologies also works for me, but until it gets merged, I like this workaround better since I only have to modify my own code.

[acar]

@hubertlepicki @bjquinn Great hack for that specific use case, but it breaks the ability to shopify.Fulfillment.find() a fulfillment because THAT request needs to go through the '.../order/<order_id>/fulfillments.json' endpoint. I suppose you could wipe it at the beginning of your function and add it back again at the end.

def example:
   shopify.Fulfillment._prefix_source = ''
   ...
   shopify.Fulfillment._prefix_source = "/orders/$order_id/"

[pama1999]

thank you all for this hack. I wonder how its possible that such bug lasts for a month. Feeling they dont give enough attention to python api :(

[Ekct00]

coolllllllllll,it works!!!!!!!!!

So I have just stumbled upon this, and I found a temporary fix, by monkey-patching the prefix on the Fulfillment resource:

shopify.Fulfillment._prefix_source = ''

Added this on top of my script after import shopify and creating fulfillments for fullfillment_orders work.

Having said that, I know nothing about Python and very little about Shopify api so please do correct me if that's some herecy. I used to be Ruby developer. Be kind to me please. ;)

[gmonacho]

Could the issue be related to the deprecation of the old order's fulfillment resource, which entered a breaking state in 2022-07? I'm not entirely certain if my comment is particularly useful, but I noticed that no one has mentioned this possibility yet. Please refer to the Shopify Changelogs for more information.

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[hubertlepicki]

Lol