Not possible to have quotes in environment variable settings

[sfriesel]

It is not possible to pass environment variable values containing quotes, e.g.

[program:x]
command=bash -c export
environment=MYSQL_PW="5ny6{wo'\"7n"

throws

ERROR: CANT_REREAD: No closing quotation

Currently shlex is used in legacy mode to parse the env settings, which does not allow any kind of escaping and also has some other odd edge cases (http://docs.python.org/2/library/shlex.html#parsing-rules). I'd propose switching the lexer to posix mode. Ideally, we would like to be able to dump any string dictionary and have it load correctly as environment for the process.

[pykler]

Bumped into this bug ... seems ubuntu keeps a rather old version of supervisor in the deb packages.

[pykler]

@mnaberez any idea why this change never made it into the supervisor releases? supervisor@3.3.0 doesn't have this change.

[mnaberez]

any idea why this change never made it into the supervisor releases? supervisor@3.3.0 doesn't have this change.

It requires Python 2.6 but the minimum required version for Supervisor 3.x is Python 2.4. This change was merged into the master branch, which will become Supervisor 4, and raises the minimum Python version to 2.6.

[jstaf]

Please merge this fix into a version 3 release of supervisor. There is no good reason to maintain compatibility for Python 2.4 at this point (it's been end-of-life for maybe a decade now - I'd be surprised to see it deployed anywhere).

[mnaberez]

Note for maintainers: Commit description 431b3a1 has more background. We tried to fix this once already but had to revert that fix because of a bug in Python stdlib.

Comments above about Python 2.4 are outdated. Support for Python versions below 2.7 was dropped in Supervisor 4.0.0 (2019-04-05). Supervisor 3.x is no longer maintained.