Improve type declarations #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Indicate that a CustomStringCallback can return undefined to indicate that no custom behavior should be applied for that node. * Allow WalkCallback to return false. Otherwise, a callback that may or may not prevent further traversal can't be expressed in TypeScript, since it doesn't allow a function to only return a value some of the time.
alexander-akait
approved these changes
Apr 21, 2020
|
What's the process for landing these PRs? Is there anything you're waiting on me for? |
|
/cc @TrySound can you review? |
TrySound
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indicate that a CustomStringCallback can return undefined to
indicate that no custom behavior should be applied for that node.
Allow WalkCallback to return false. Otherwise, a callback that may
or may not prevent further traversal can't be expressed in
TypeScript, since it doesn't allow a function to only return a value
some of the time.