Skip to content

fix(docs): remove --branch flag from git clone command for bleeding edge setup in Installation.md #6164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

louisgthier
Copy link
Contributor

The --branch flag was causing a fatal error during the cloning process:
"fatal: You must specify a repository to clone."

Proposed change(s)

This PR removes the --branch flag from the git clone command in Installation.md, which was incorrectly used and caused cloning to fail for the bleeding edge version.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

(Provide any relevant links here, if available)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

No additional comments or changes required beyond fixing the command error in the documentation.

…dge setup in Installation.md

The `--branch` flag was causing a fatal error during the cloning process:
"fatal: You must specify a repository to clone."
@CLAassistant
Copy link

CLAassistant commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

…onditioning_type`

Updated the documentation to reflect the correct config setting name `goal_conditioning_type` instead of `conditioning_type` in the config YAML. This ensures accuracy and prevents potential confusion for users following the documentation.
@louisgthier
Copy link
Contributor Author

I’ve also updated the documentation to correct the config setting name from conditioning_type to goal_conditioning_type.

Copy link
Contributor

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miguelalonsojr miguelalonsojr merged commit cfb26e3 into Unity-Technologies:develop Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants