Skip to content

PYTHON-PACKAGE-007 Add develop flag to analyze function #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2024
Merged

PYTHON-PACKAGE-007 Add develop flag to analyze function #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions NLPPlus/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def __init__(
)
self.engine = NLP_ENGINE(str(self.working_folder), silent=not verbose)

def analyze(self, text: str, analyzer_name: str) -> Results:
def analyze(self, text: str, analyzer_name: str, develop: bool = False) -> Results:
"""Analyze text with the named analyzer."""
analyzer_name = Path(analyzer_name)
outdir = self.working_folder / "analyzers" / analyzer_name / "output"
Expand All @@ -118,7 +118,7 @@ def analyze(self, text: str, analyzer_name: str) -> Results:
file_list = glob.glob(str(outdir / "*"))
for file_path in file_list:
os.remove(file_path)
outtext = self.engine.analyze(str(analyzer_name), text)
outtext = self.engine.analyze(str(analyzer_name), text, develop)
return Results(outtext, outdir)

def input_text(self, analyzer_name: str, file_name: str) -> str:
Expand Down Expand Up @@ -182,9 +182,9 @@ def set_analyzers_folder(analyzer_folder_path: str):
engine.set_analyzers_folder(analyzer_folder_path)


def analyze(text: str, parser: str = "parse-en-us"):
def analyze(text: str, parser: str = "parse-en-us", develop: bool = False) -> str:
"""Run the analyzer named on the input string."""
return engine.analyze(text, parser).output_text
return engine.analyze(text, parser, develop).output_text


def input_text(analyzer_name: str, file_name: str):
Expand Down
6 changes: 3 additions & 3 deletions bindings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ using namespace nb::literals;
*/
const std::string
wrap_analyze(NLP_ENGINE &engine, const std::string &parser,
const std::string &input) {
const std::string &input, const bool develop=false) {
_TCHAR *_parser = _tcsdup(parser.c_str());
std::istringstream instream(input);
std::ostringstream outstream;
int rv = engine.analyze(_parser, &instream, &outstream);
int rv = engine.analyze(_parser, &instream, &outstream, develop);
free(_parser);
return outstream.str();
}
Expand All @@ -42,7 +42,7 @@ NB_MODULE(bindings, m) {
"workingFolder"_a = ".",
"silent"_a = true)
.def("analyze", &wrap_analyze,
"parser"_a, "input"_a,
"parser"_a, "input"_a, "develop"_a,
"Analyze `input` with `parser`.\n"
"The `parser` argument refers to an analyzer contained in the\n"
"`analyzers` folder inside the workingFolder used to create\n"
Expand Down
Loading