Skip to content

Remove legacy GC encodings #5874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Remove legacy GC encodings #5874

merged 2 commits into from
Mar 12, 2024

Conversation

tlively
Copy link
Member

@tlively tlively commented Aug 10, 2023

It was previously possible to opt in to using the legacy GC opcodes with a build
time flag. Now that WasmGC has shipped and users have migrated to the standard
opcodes, remove the option to use the legacy encodings.

@tlively tlively requested a review from kripken August 10, 2023 20:59
@tlively
Copy link
Member Author

tlively commented Aug 10, 2023

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlively and the rest of your teammates on Graphite Graphite

@tlively
Copy link
Member Author

tlively commented Aug 10, 2023

This is meant to be landed after the GC proposal goes to phase 4 and the proposal has shipped by default in browsers that previously supported the legacy encodings. In the time between those two events, users can still choose at Binaryen build time whether they want to target the GC experiment on stable browsers using the legacy encodings or newer pre-release versions of browsers that support the standard encodings.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.46%. Comparing base (b671b6c) to head (9118d78).

❗ Current head 9118d78 differs from pull request most recent head d475502. Consider uploading reports for the commit d475502 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5874      +/-   ##
==========================================
- Coverage   48.86%   42.46%   -6.41%     
==========================================
  Files         511      482      -29     
  Lines       78407    74725    -3682     
  Branches    12410    11931     -479     
==========================================
- Hits        38312    31730    -6582     
- Misses      36671    39787    +3116     
+ Partials     3424     3208     -216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from default-gc-standard-opcodes to main September 12, 2023 21:05
It was previously possible to opt in to using the legacy GC opcodes with a build
time flag. Now that WasmGC has shipped and users have migrated to the standard
opcodes, remove the option to use the legacy encodings.
@tlively tlively force-pushed the only-gc-standard-opcodes branch from 9118d78 to 5a808c0 Compare March 12, 2024 18:24
@tlively
Copy link
Member Author

tlively commented Mar 12, 2024

I'm going to go ahead and land this once the tests have passed.

@tlively tlively enabled auto-merge (squash) March 12, 2024 18:28
@tlively tlively merged commit 3edc08c into main Mar 12, 2024
@tlively tlively deleted the only-gc-standard-opcodes branch March 12, 2024 22:56
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants