Check for unreachable in Select::finalize(Type)
#6389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Unfortunately I no longer have the test case the fuzzer produced, but hopefully this is straightforward enough to land anyway. |
Previously selects finalized with explicit types would never be marked unreachable, even when they should have been.
tlively
force-pushed
the
select-finalize-fix
branch
from
f77328a to
5e68848
Compare
kripken
reviewed
Mar 8, 2024
src/wasm/wasm.cpp
Outdated
| void Select::finalize(Type type_) { type = type_; } | ||
| void Select::finalize(Type type_) { | ||
| assert(ifTrue && ifFalse); | ||
| if (ifTrue->type == Type::unreachable || ifFalse->type == Type::unreachable) { |
There was a problem hiding this comment.
I think this should also include the condition?
kripken
approved these changes
Mar 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously selects finalized with explicit types would never be marked
unreachable, even when they should have been.