Skip to content

Heap2Local: Fix signed struct/array reads #6484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 10, 2024

In #6480 I forgot that StructGet can be signed, which means we need to emit
a sign-extend.

Arrays were already ok as the field signed_ was simply copied (but then, as a
struct, it was ignored).

@kripken kripken requested a review from tlively April 10, 2024 20:47
@kripken kripken merged commit 6236dc3 into WebAssembly:main Apr 10, 2024
@kripken kripken deleted the heap2local.signed_get branch April 10, 2024 21:14
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants