[Strings] Remove operations not included in imported strings #6589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I would personally be more cautious about removing stuff, since imported strings may expand 😄 but sgtm if you are willing to restore stuff that ends up necessary. |
|
Yep, I can sign myself up for that. |
kripken
reviewed
May 14, 2024
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| (func $yes-new-past-store |
There was a problem hiding this comment.
We don't seem to have any yes-new-* functions after this removal, so we might be losing coverage here.
tlively
force-pushed
the
no-stringref-ops
branch
3 times, most recently
from
43a188f to
df5f581
Compare
The stringref proposal has been superseded by the imported JS strings proposal, but the former has many more operations than the latter. To reduce complexity, remove all operations that are part of stringref but not part of imported strings.
Closed
CountBleck
added a commit
to CountBleck/binaryen
that referenced
this pull request
Jun 1, 2025
The definition for this function was removed in WebAssembly#6589.
kripken
pushed a commit
that referenced
this pull request
Jun 4, 2025
The definition for this function was removed in #6589.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stringref proposal has been superseded by the imported JS strings proposal,
but the former has many more operations than the latter. To reduce complexity,
remove all operations that are part of stringref but not part of imported
strings.