Add --internal-cookie-store option for Playground CLI #2323
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
adamziel
commented
Jul 3, 2025
| @@ -593,6 +602,7 @@ export async function runCLI(args: RunCLIArgs): Promise<RunCLIServer> { | |||
| processIdSpaceLength, | |||
| followSymlinks, | |||
| trace, | |||
| disableCookieStore: !args.internalCookieStore, | |||
There was a problem hiding this comment.
let's use a consistent internalCookieStore name everywhere and also add a README entry before merging.
There was a problem hiding this comment.
I have created a PR for it: #2325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
--internal-cookie-storeflag in the Playground CLI and a correspondinginternalCookieStoreargument inRunCLIArgs. When enabled, all the cookies are stored and served from an internal cookie jar. By default, that option is disabled and the user agent is responsible for handling cookies.Motivation
Some workflows need Playground to own cookie persistence, e.g. VS Code webview does not store cookies so any Blueprint with autologin enabled results in an infinite redirection loop.
Testing steps
set-cookieheader both on the homepage and when logging in.--internal-cookie-storeand verify no cookies are sent to the browser. Confirm the admin login form still works.cc @bgrgicak @ryanwelcher