Fit row height to content

[mikhail-eremin]

I found issue for that but it is closed now because of "there is a plugin" (#21).
But what that plugin does in only make all table row heights bigger if table is too small for screen(and by the way it's very buggy in that work). It is not a solution at all!

Equal fixed height of row for whole table is a bad idea in case of inconsistent table data. For example, i can have a list in a cell, so row should have a bigger height, or there can be a picture, or it can be only a short strings so we don't need row to be very big. I can't hide contents to popover or so, ngGrid should have option to make it visible, like all tables do!

I was so happy when i found ngGrid, it's cool component, really thanx! 👍 But dynamic row height issue is critical for our project, so i can't use it now(
Don't let us go back to jqGrid please

[orneryd]

i see what you mean. it really isn't what I thought it was intended to be. I have been spending some time thinking about thie problem and I am pretty sure it will take some major overhauls to the basic structure of the grid to make the variable height (fit to content) simply because we use position: absolute; divs instead of a table..

[orneryd]

We have made a decision and this will unfortunately not be supported by ng-grid. If you need dynamically sized rows then you will want to use data-tables or some other grid that is based on a table structure. if we changed the way we did the rows we would take a massive performance hit for what we are trying to achieve here.

[orneryd]

FYI, slickgrid (which is our main influence) does not support this either.

This is a killer for me ...

[getuliojr]

I took a look at this problem today, and it was not too hard to solve it. Took me a day of work but it is way better for my taste now. Take a look at the image to see how it renders the rows. Was something like that you were after ? I will do a PR so it can help others.

[swalters]

@getuliojr , we will no longer be accepting pull requests for new features on 2.x branches. Only 3.0 pull requests will be considered. We are in the process of making this official somewhere on the site.

[getuliojr]

Ok. I am still on 2.x. I will not PR this feature. :) In the future when I am on 3.x if this still a problem I´ll take a look. Thanks :)

[kabb5]

What a tease! Would love to see the code behind the image posted by @getuliojr

[getuliojr]

I can fork and PR on my repository if that helps. I am using it for some time now and is working just fine. Other fixes that I added was:

• I patched the height so I don´t need to set the height of the grid on the markup and so if just one or two data itens is in the ng-grid it will shrink or expand accordly. Don´t take the extra spaces.
• It is responsive, so If I shrink or expand the window it will follow. Below is another example:

[kabb5]

@getuliojr that would be great, thanks - I think this is what @mikhail-eremin was looking for, too

[rraaij]

@getuliojr does your solution also work in combination with pinnable columns? I tried the CSS-solution, but that has the unwanted side effect that stops the pinnable column from working. (i.e. it scrolls out of screen with all the other columns, whether it's pinned or not)

[eruizdechavez]

@getuliojr I'd love as well to have a better idea of your changes; I forked your fork but I am not able to neither create dynamic height rows nor identify your specific changes.