Pagination missing rows

[dllabs]

With enableVerticalScrollbar set to false, pagination doesn't show all the rows on tables with automatically computed lengths. see this plunker:
http://plnkr.co/edit/KThG1GEIvDYYyOqQqrpH?p=preview

I was expecting that if I set the paginationPageSize to, say, 10, I would see 10 rows on a page, rather than 9 or (if the filtering is enabled) 8.

I know users can sort of scroll inside the table even when the scrollbar is turned off, but that's not an obvious feature and many users will simply never see the last rows.

At the moment I am working around it by setting minRowsToShow to one more than paginationPageSize, but that isn't always suitable. Neither is manually setting the height of the table in css. Sometimes I will have tables with fewer rows than the paginationPageSize, and I want the table length to shrink accordingly.

Am I thinking about this wrong or is this an issue?

cheers

John

[c0bra]

Well that stinks. Definitely looks like the 10th row is being cut off. Thanks for filing this.

[anilnatha]

Just wanted to add that modifying the minRowsToShow columndef to be one more than the number you actually want also mitigates the issue, although I agree it's not ideal. I have a Angular Service I wrote to determine the height of my grid, and had to modify it to account for the +1 row bug to auto-shrink my grid when the page has less than the number of records to display per page.

However, in changing the minRowsToShow or the paginationPageSize columndef options to be +1, the pagination page sizes dropdown doesn't display anything unless you also increase each of the values of the paginationPageSizes dropdown by 1.

[anilnatha]

Is Line 371 of pagination.js the culprit?

$scope.showingLow = ((options.paginationCurrentPage - 1) * options.paginationPageSize) + 1;