Create new tag on blur of searchInput #1001
Conversation
|
@eduardonunesptoptal While I'd love this feature, the plunkr you posted does not seem to work. Maybe you linked to the wrong plunkr? |
|
Yeah, it works only in if you press Tab to change field or press Enter. Sorry. |
|
@karptonite @mattmcardle |
|
I'm using the branch on our beta site, but being functional doesn't necessarily mean it is ready to merge. |
|
Karp - Thanks for immediate response, Good to hear that. When can I consume this great feature tag-on-blur, since I'm in critical delivery I would like to use this. Is this possible to get ride of new feature anywhere? |
|
@jeyakrishnanp If you nee this immediately, I recommend that you fork ui-select and merge in @mattmcardle's changes. That is what I did (that is my only connection to this--I have no say in when or if this is ever merged). |
|
@mattmcardle - can you resolve the conflicts and raise request for merge |
Conflicts: dist/select.css dist/select.js dist/select.min.css dist/select.min.js
|
@jeyakrishnanp @karptonite I have resolved conflicts and this branch is ready for merging. |
|
@mattmcardle I hate to say it, but as much as I want this feature, this pull request should not be accepted. First, you shouldn't have changes to dist in your pull request (see the bottom of the readme). Second, for adding a new feature, you should also add associated tests so that we can be sure that future changes don't break the feature. |
Conflicts: dist/select.css dist/select.js dist/select.min.css dist/select.min.js
| @@ -131,7 +141,7 @@ | |||
| <p>Selected: {{person.selected}}</p> | |||
|
|
|||
| <h3>Tagging without multiple, with simple strings</h3> | |||
| <ui-select tagging tagging-label="('new')" ng-model="singleDemo.color" theme="bootstrap" style="width: 800px;" title="Choose a color"> | |||
| <ui-select tagging tagging-label="('new')" ng-model="singleDemo.color" theme="bootstrap" style="width: 800px;"title="Choose a color"> | |||
There was a problem hiding this comment.
space removed before title=
|
History needs to be cleaned up - there should be no merge commits. |
Implement `tagging-on-blur` option on `ui-select` directive. This closes angular-ui#544 and is a cleanup of PR angular-ui#1001 that never got merged because of formatting issues.
As in this issue, I had a requirement in my project for a tag to be created when focus had left the search input. To try enable the creation of tags on blur, add the attribute tag-on-blur="true" to the ui-select directive.