Document 'platform' option for Angular Compiler Plugin / consider string enum

[josephliccini]

Bug Report or Feature Request (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x ] feature request

Versions.

1.5.0 (ejected webpack config)

Desired functionality.

When one does ng eject --prod --aot we see that in the Angular Compiler Options, platform: 0.

Maybe it could use a String enum for this enum:

angular-cli/packages/@ngtools/webpack/src/angular_compiler_plugin.ts

Lines 78 to 82 in cb53fb9

	export enum PLATFORM {
	Browser,
	Server
	}

Could be changed to:

export const enum PLATFORM {
    Browser = 'Browser',
    Server = 'Server'
}

Which would produce in the ejected webpack config:

new AngularCompilerPlugin({
    ...
    platform: 'Browser'
});

Thoughts?

Thanks!
Joe

[filipesilva]

Heya, what would be the benefit of this? We do export the available platform enum so that it can be imported with no breakage in case the underlying representation changes. That approach seems more versatile than trying it to a string.

[alan-agius4]

Closing as no further information was provided by the author of the issue.

If the problem persists after upgrading, please open a new issue, provide a simple repository reproducing the problem, and describe the difference between the expected and current behavior.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}