Implement filtering on object-based ng-repeat

[quantizor]

Currently if you are using the ng-repeat directive to walk over the properties of a non-array object, filters will not work as they test immediately if the collection is an array and reject anything not matching.

This behavior can be seen here:

angular.js/src/ng/filter/filter.js

Line 118 in 06f2ba8

if (!isArray(array)) return array;

(thanks @caitp !)

This is an undocumented and - per #6215 - potentially unwanted behavior, since the syntax is the same for iterating over arrays and objects. Plus, it's just darn useful!

Opening up the lines of discussion here to see if it's worth implementing filter functionality for objects and not just straight array/array-like structures.

[smithl]

+1

[paishin]

+1

[prady00]

+1 nice to have!
On 26-Oct-2014 5:34 am, "paishin" notifications@github.com wrote:

+1

Reply to this email directly or view it on GitHub
#6490 (comment).

[quantizor]

@gkalpak Been a while since I looked at this code :) what would you like changed in regards to the tests?

[gkalpak]

@3lux: Not really sure :) It's more of a fuzzy feeling. I sure don't like the "obscure" helpers (maybe just because I don't get their usefulness). I had left some inline comments the other day.