Make GenericDialect support trailing commas in projections
#1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to apache#1911. The docs for GenericDialect says that is can be permissive, so I thought it could support trailing commas in projections. This would help a bit on the "friendly sql" issue apache/datafusion#14514
simonvandel
force-pushed
the
generic-support-trailing-comma
branch
from
0a261dd to
44ceeda
Compare
iffyio
reviewed
Jul 3, 2025
| let trailing_commas = TestedDialects::new(vec![Box::new(GenericDialect {})]); | ||
|
|
||
| assert_eq!( |
There was a problem hiding this comment.
could we instead change this to use a dialect like postgres that doesnt support trailing commas? thinking that would let us keep the negative test around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1911.
The docs for GenericDialect says that is can be permissive, so I thought it could support trailing commas in projections.
This would help a bit on the "friendly sql" issue
apache/datafusion#14514
I removed a test-case that tested that ´GenericDialect
did not support trailing commas in projections. Positive tests for trailing commas still exists in theparse_projection_trailing_comma` test