[#6695] fix(authz): Fix the error privileges #6821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Don‘t forget to delete these defines.
public class PathBasedMetadataObject implements AuthorizationMetadataObject {
public static final PathType METALAKE_PATH = new PathType(MetadataObject.Type.METALAKE);
public static final PathType CATALOG_PATH = new PathType(MetadataObject.Type.CATALOG);
public static final PathType SCHEMA_PATH = new PathType(MetadataObject.Type.SCHEMA);
public static final PathType TABLE_PATH = new PathType(MetadataObject.Type.TABLE);
public static final PathType FILESET_PATH = new PathType(MetadataObject.Type.FILESET);
There was a problem hiding this comment.
cc @yuqi1129 This follows yu's suggestion.
yuqi1129
reviewed
Apr 8, 2025
| @@ -740,4 +776,39 @@ protected Map<String, String> getServiceConfigs(Map<String, String> config) { | |||
| RangerAuthorizationProperties.FS_DEFAULT_VALUE)) | |||
| .build(); | |||
| } | |||
|
|
|||
| private interface PathExtractor { | |||
| String getPath(Entity.EntityType type, String location); | |||
There was a problem hiding this comment.
Please add some comments regarding the method and its corresponding parameters.
| return location; | ||
| } else { | ||
| throw new AuthorizationPluginException( | ||
| "Don't support %s to get table or fileset location", type); |
There was a problem hiding this comment.
It's not allowed/supported to extract table or fileset path from entity %s
| @@ -92,15 +92,26 @@ public String toString() { | |||
| private final String name; | |||
| private final String parent; | |||
| private final String path; | |||
| private final boolean isRecursive; | |||
There was a problem hiding this comment.
I do like the name isRecursive, you may use recursive instead as there exists a method name isRecursive()
yuqi1129
approved these changes
Apr 8, 2025
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Apr 9, 2025
### What changes were proposed in this pull request? Fix the error privileges. ### Why are the changes needed? Fix: apache#6695 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Apr 15, 2025
### What changes were proposed in this pull request? Fix the error privileges. ### Why are the changes needed? Fix: apache#6695 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Apr 27, 2025
### What changes were proposed in this pull request? Fix the error privileges. ### Why are the changes needed? Fix: apache#6695 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add UT.
Abyss-lord
pushed a commit
to Abyss-lord/gravitino
that referenced
this pull request
Jun 16, 2025
Fix the error privileges. Fix: apache#6695 No. Add UT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix the error privileges.
Why are the changes needed?
Fix: #6695
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add UT.