HADOOP-19597. Log warning message on every set/get of a deprecated configuration property #7766

zabetak · 2025-06-27T12:59:36Z

Description of PR

Log warning message on every access to a deprecated property to avoid the risk of losing important deprecation messages that appear early on during APP startup and increase user awareness. See HADOOP-19597 for full motivation and relevant history around this feature.

How was this patch tested?

mvn test -pl hadoop-common-project/hadoop-common

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…nfiguration property

hadoop-yetus · 2025-06-27T15:11:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 1s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	23m 35s		trunk passed
+1 💚	compile	8m 29s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	7m 24s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 42s		trunk passed
+1 💚	mvnsite	0m 55s		trunk passed
+1 💚	javadoc	0m 47s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 35s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 31s		trunk passed
+1 💚	shadedclient	22m 15s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	8m 3s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	8m 3s		the patch passed
+1 💚	compile	7m 29s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	7m 29s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 41s		the patch passed
+1 💚	mvnsite	0m 59s		the patch passed
+1 💚	javadoc	0m 42s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 35s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
-1 ❌	spotbugs	1m 37s	/new-spotbugs-hadoop-common-project_hadoop-common.html	hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	shadedclient	22m 19s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 43s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		131m 12s

Reason	Tests
SpotBugs	module:hadoop-common-project/hadoop-common
	Private method org.apache.hadoop.conf.Configuration$DeprecatedKeyInfo.getWarningMessage(String) is never called At Configuration.java:called At Configuration.java:[line 383]

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7766/1/artifact/out/Dockerfile
GITHUB PR	#7766
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c205d1d6c004 5.15.0-136-generic #147-Ubuntu SMP Sat Mar 15 15:53:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b572ee3`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7766/1/testReport/
Max. process+thread count	3151 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7766/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-06-29T06:56:26Z

@zabetak Thanks for the contribution! In my opinion, this PR makes sense, but we need to fix the SpotBugs issues.

zabetak · 2025-07-01T08:41:06Z

Thanks for the review @slfan1989 ! I fixed the SpotBug warning in 7412e89.

hadoop-yetus · 2025-07-01T10:19:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 18s		trunk passed
+1 💚	compile	8m 23s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	7m 58s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	0m 40s		trunk passed
+1 💚	mvnsite	0m 55s		trunk passed
+1 💚	javadoc	0m 42s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 32s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 33s		trunk passed
+1 💚	shadedclient	23m 37s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 32s		the patch passed
+1 💚	compile	8m 10s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	8m 10s		the patch passed
+1 💚	compile	7m 37s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	7m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 36s		hadoop-common-project/hadoop-common: The patch generated 0 new + 210 unchanged - 1 fixed = 210 total (was 211)
+1 💚	mvnsite	0m 50s		the patch passed
+1 💚	javadoc	0m 39s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 28s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	1m 33s		the patch passed
+1 💚	shadedclient	23m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	19m 52s		hadoop-common in the patch passed.
+1 💚	asflicense	0m 43s		The patch does not generate ASF License warnings.
		134m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7766/2/artifact/out/Dockerfile
GITHUB PR	#7766
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 76c3b62ca2b4 5.15.0-142-generic #152-Ubuntu SMP Mon May 19 10:54:31 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7412e89`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7766/2/testReport/
Max. process+thread count	1262 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7766/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-07-02T07:51:02Z

@zabetak Thank you for your contribution! If there are no further comments, I will merge this PR in 2 days.

HADOOP-19597. Log warning message on every set/get of a deprecated co…

b572ee3

…nfiguration property

github-actions bot added trunk Common labels Jun 27, 2025

slfan1989 approved these changes Jun 29, 2025

View reviewed changes

Removed unused method in DeprecatedKeyInfo to solve spotbugs warning

7412e89

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-19597. Log warning message on every set/get of a deprecated configuration property #7766

HADOOP-19597. Log warning message on every set/get of a deprecated configuration property #7766

zabetak commented Jun 27, 2025

Uh oh!

hadoop-yetus commented Jun 27, 2025

Uh oh!

slfan1989 commented Jun 29, 2025

Uh oh!

zabetak commented Jul 1, 2025

Uh oh!

hadoop-yetus commented Jul 1, 2025

Uh oh!

slfan1989 commented Jul 2, 2025

Uh oh!

Uh oh!

HADOOP-19597. Log warning message on every set/get of a deprecated configuration property #7766

Are you sure you want to change the base?

HADOOP-19597. Log warning message on every set/get of a deprecated configuration property #7766

Conversation

zabetak commented Jun 27, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Jun 27, 2025

Uh oh!

slfan1989 commented Jun 29, 2025

Uh oh!

zabetak commented Jul 1, 2025

Uh oh!

hadoop-yetus commented Jul 1, 2025

Uh oh!

slfan1989 commented Jul 2, 2025

Uh oh!

Uh oh!