Rest: Implement register table #1521
Conversation
gabeiglio
force-pushed
the
rest-register-table
branch
from
0bfda56 to
5c342f3
Compare
| StatusCode::SERVICE_UNAVAILABLE => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "The service is not ready to handle the request.", | ||
| )); | ||
| } | ||
| StatusCode::INTERNAL_SERVER_ERROR => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "An unknown server-side problem occurred; the commit state is unknown.", | ||
| )); |
| StatusCode::UNAUTHORIZED => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "Authenticated user does not have the necessary permissions.", | ||
| )); | ||
| } | ||
| StatusCode::FORBIDDEN => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "Authenticated user does not have the necessary permissions.", | ||
| )); | ||
| } |
There was a problem hiding this comment.
Also not sure if we need to check for these cases
There was a problem hiding this comment.
Following iceberg-java's error handling logic, I think it's necessary to handle all of these error codes
gabeiglio
force-pushed
the
rest-register-table
branch
from
5c342f3 to
574069f
Compare
There was a problem hiding this comment.
Hi @gabeiglio , thanks for your contribution! I've left some suggestions
| } | ||
| StatusCode::CONFLICT => { | ||
| return Err(Error::new( | ||
| ErrorKind::TableAlreadyExists, |
There was a problem hiding this comment.
This should use ErrorKind::CatalogCommitConflicts and should be explicitly set to retryable using with_retryable(true)
| @@ -745,10 +749,86 @@ impl Catalog for RestCatalog { | |||
| _table_ident: &TableIdent, | |||
There was a problem hiding this comment.
the _ prefix is for unused variables, we should remove it since now it's implemented
| @@ -745,10 +749,86 @@ impl Catalog for RestCatalog { | |||
| _table_ident: &TableIdent, | |||
| _metadata_location: String, | |||
| StatusCode::UNAUTHORIZED => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "Authenticated user does not have the necessary permissions.", | ||
| )); | ||
| } | ||
| StatusCode::FORBIDDEN => { | ||
| return Err(Error::new( | ||
| ErrorKind::Unexpected, | ||
| "Authenticated user does not have the necessary permissions.", | ||
| )); | ||
| } |
There was a problem hiding this comment.
Following iceberg-java's error handling logic, I think it's necessary to handle all of these error codes
| let metadata_location = response.metadata_location.as_ref().ok_or(Error::new( | ||
| ErrorKind::DataInvalid, | ||
| "Metadata location missing in `register_table` response!", | ||
| ))?; |
There was a problem hiding this comment.
nit: this can be slightly simplified using some syntax sugar
let Some(metadata_location) = response.metadata_location else { return Err(Error::new(...)) }
let file_io = self.load_file_io(metadata_location, None).await?;
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Im new to Rust so any feedback is welcomed! :)