refactor: Add read_from() and write_to() to TableMetadata
#1523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
changed the title
TableMetadataIO to read and write metadataread() and write() to TableMetadata
CTTY
commented
Jul 19, 2025
crates/catalog/glue/src/catalog.rs
Outdated
| .new_output(&metadata_location)? | ||
| .write(serde_json::to_vec(&metadata)?.into()) | ||
| .await?; | ||
| TableMetadata::write(&self.file_io, &metadata, &metadata_location).await?; |
There was a problem hiding this comment.
I also found MetadataLocation proposed here quite interesting:
Would love to hear more thoughts about it
There was a problem hiding this comment.
I think this should not change the interface here. We could change the write interface to sth like following:
fn write(&self, impl ToString)to generalize the arguments.
There was a problem hiding this comment.
I changed it to
fn write(&self, impl AsRef<str>)
because file_io.new_input/new_output takes AsRef<str>
liurenjie1024
previously approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Thanks @CTTY for this pr, generally LGTM! Just one minor nit!
crates/catalog/glue/src/catalog.rs
Outdated
| .new_output(&metadata_location)? | ||
| .write(serde_json::to_vec(&metadata)?.into()) | ||
| .await?; | ||
| TableMetadata::write(&self.file_io, &metadata, &metadata_location).await?; |
There was a problem hiding this comment.
I think this should not change the interface here. We could change the write interface to sth like following:
fn write(&self, impl ToString)to generalize the arguments.
CTTY
changed the title
read() and write() to TableMetadataread_from() and write_to() to TableMetadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
TableMetadatato new location. #1388What changes are included in this PR?
TableMetadataIOto read/write metadata from/to a locationAre these changes tested?
Added unit test