Skip to content

infra: use toml-cli to manually set version in github action #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Jul 22, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

See comment for context
Previously used cargo-edit but it does not allow setting version from 0.6.0 -> 0.6.0-rc1.

This PR changes the github action to use toml-cli to manually override and set the version in the binding/python/Cargo.toml so that we can build pre-release artifacts to push to pypi.

Are these changes tested?

Yes, similar to #1449

Pushed this PR as the main branch in my fork
Create a new tag and push to fork to trigger CI

git tag "v0.6.0-rc.2" -m "v0.6.0-rc.2"
git push kevinjqliu v0.6.0-rc.2

Verify that python artifacts are build correctly with pre-release tag, https://github.com/kevinjqliu/iceberg-rust/actions/runs/16436181005

  • downloaded wheels-sdist, verified correct version in PKG-INFO but not in Cargo.toml. I think this is fine
  • downloaded wheels-ubuntu-latest-armv7l and verified the METADATA file

@kevinjqliu kevinjqliu marked this pull request as ready for review July 22, 2025 06:25
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this change, thank you @kevinjqliu

@kevinjqliu
Copy link
Contributor Author

downloaded wheels-sdist, verified correct version in PKG-INFO but not in Cargo.toml. I think this is fine

@Xuanwo can you double check this statement? I think its fine esp because since we only care that pypi parse the artifact as pre-release. But want to get a second opinion. :)

@Xuanwo
Copy link
Member

Xuanwo commented Jul 22, 2025

I think its fine esp because since we only care that pypi parse the artifact as pre-release. But want to get a second opinion. :)

Yep, I think it's fine.

@kevinjqliu kevinjqliu merged commit 9787140 into apache:main Jul 22, 2025
26 of 27 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-github-action-set-version branch July 22, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants