KAFKA-19272: Add initPid Response handling when keepPrepared is set to true (KIP-939) #20039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
rreddy-22
changed the title
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
Outdated
Show resolved
Hide resolved
| @@ -29,6 +29,7 @@ | |||
| import org.apache.kafka.clients.producer.internals.BufferPool; | |||
| import org.apache.kafka.clients.producer.internals.BuiltInPartitioner; | |||
| import org.apache.kafka.clients.producer.internals.KafkaProducerMetrics; | |||
| import org.apache.kafka.clients.producer.internals.PreparedTxnState; | |||
There was a problem hiding this comment.
This is public class, it shouldn't be in internals.
| @@ -349,7 +348,7 @@ public synchronized void prepareTransaction() { | |||
| maybeFailWithError(); | |||
| transitionTo(State.PREPARED_TRANSACTION); | |||
| this.preparedTxnState = new PreparedTxnState( | |||
| this.producerIdAndEpoch.producerId + ":" + | |||
| this.producerIdAndEpoch.producerId, | |||
There was a problem hiding this comment.
Let's just change the type of preparedTxnState member to be private volatile ProducerIdAndEpoch preparedTxnState then we can just assign numbers to it (it even has a convenient NONE constant). Then the KafkaProducer would create the corresponding PreparedTxnState object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initPid(keepPrepared = true) is called after a client crashes, several situations should be considered.
When there's an ongoing transaction, we can transition it to the newly added PREPARED_TRANSACTION state. However, what if there's no ongoing transaction?
Another scenario could be:
Solution:
This is a perfectly valid scenario as the external transaction coordinator for the 2PC transaction will keep committing participants, and the participants need to eventually return success (that's a guarantee for a prepared transaction).
Rejected Alt 1 -> Return an InvalidTxnStateException : Returning an error would break the above scenario.
Rejected Alt 2 -> Then the next thought is that we should somehow validate if the state is expected, but we don't have data to validate the result against.
Final Solution: Just returning the success and transitioning to READY is the proper handling of this condition.