KAFKA-19463: nextFetchOffset does not take ongoing state transition into account #20080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Comment on lines
2091
to
2093
| if (state.state != RecordState.ARCHIVED) { | ||
| findNextFetchOffset.set(true); | ||
| } |
There was a problem hiding this comment.
This change here makes sense, but do we need to remove findNextFetchOffset.set(true); at other places where we just started the transaction i.e. in acknowledgement?
There was a problem hiding this comment.
Yes, that makes sense. I have created https://issues.apache.org/jira/browse/KAFKA-19464 to handle it for the future.
| @@ -2088,6 +2088,9 @@ void rollbackOrProcessStateUpdates( | |||
| state.completeStateTransition(true); | |||
| // Cancel the acquisition lock timeout task for the state since it is acknowledged/released successfully. | |||
| state.cancelAndClearAcquisitionLockTimeoutTask(); | |||
| if (state.state != RecordState.ARCHIVED) { | |||
There was a problem hiding this comment.
Should it be:
Suggested change
| if (state.state != RecordState.ARCHIVED) { | |
| if (state.state == AVAILABLE) { |
Comment on lines
7391
to
7392
| // Mocking the persister write state RPC to return future 1 when acknowledgement occurs for offsets 0-9. | ||
| // Mocking the persister write state RPC to return future 2 when acknowledgement occurs for offsets 10-19. |
There was a problem hiding this comment.
Suggested change
| // Mocking the persister write state RPC to return future 1 when acknowledgement occurs for offsets 0-9. | |
| // Mocking the persister write state RPC to return future 2 when acknowledgement occurs for offsets 10-19. | |
| // Mocking the persister write state RPC to return future 1 and future 2 when acknowledgement occurs for offsets 0-9 and 10-19 respectively. |
Comment on lines
7438
to
7439
| // Mocking the persister write state RPC to return future 1 when acknowledgement occurs for offsets 5-9. | ||
| // Mocking the persister write state RPC to return future 2 when acknowledgement occurs for offsets 20-24. |
apoorvmittal10
approved these changes
Jul 2, 2025
jiafu1115
pushed a commit
to jiafu1115/kafka
that referenced
this pull request
Jul 3, 2025
…nto account (apache#20080) ### About `nextFetchOffset` function in `SharePartition` updates the fetch offsets without considering batches/offsets which might be undergoing state transition. This can cause problems in updating to the right fetch offset. ### Testing The new code added has been tested with the help of unit tests. Reviewers: Apoorv Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
nextFetchOffsetfunction inSharePartitionupdates the fetch offsets without considering batches/offsets which might be undergoing state transition. This can cause problems in updating to the right fetch offset.Testing
The new code added has been tested with the help of unit tests.
Reviewers: Apoorv Mittal [email protected]