Move to docc documentation #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
ktoso-patch-1
branch
2 times, most recently
from
8d86d38 to
1efc24b
Compare
|
The nightly failure is somethign we must fix independently: #17 |
yim-lee
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Some minor suggestions. LGTM overall.
Perhaps should wait for the outcome of the discussion around Package.swift in apple/swift-statsd-client#36 before merging.
|
|
||
| This makes the System Metrics API available. This adds a new method to `MetricsSystem` called `bootstrapWithSystemMetrics`. Calling this method will call `MetricsSystem.bootstrap` as well as bootstrapping System Metrics. | ||
|
|
||
| `bootstrapWithSystemMetrics` takes a `SystemMetrics.Configuration` object to configure the system metrics. The config has the following properties: |
There was a problem hiding this comment.
Can these references be links? (i.e., ``SystemMetrics.Configuration``)
There was a problem hiding this comment.
Sadly not across modules :-(
|
Added CI for Swift 5.6 and 5.7. @swift-server-bot test this please |
|
Okey I chimed in on apple/swift-statsd-client#36 THanks for review! |
tomerd
reviewed
Aug 4, 2022
yim-lee
reviewed
Aug 5, 2022
tomerd
reviewed
Aug 6, 2022
some initial docc preparation remove jazzy we need ruby still formatting docker cleanups some more docs for the types Apply suggestions from code review Co-authored-by: Yim Lee <[email protected]> license fix
yim-lee
reviewed
Aug 23, 2022
| @@ -88,7 +88,7 @@ for language in swift-or-c bash dtrace; do | |||
| matching_files=( -name '*' ) | |||
| case "$language" in | |||
| swift-or-c) | |||
| exceptions=( -name c_nio_http_parser.c -o -name c_nio_http_parser.h -o -name cpp_magic.h -o -name Package.swift -o -name CNIOSHA1.h -o -name c_nio_sha1.c -o -name ifaddrs-android.c -o -name ifaddrs-android.h) | |||
| exceptions=( -name Package.swift -o -name Package@*.swift ) | |||
There was a problem hiding this comment.
I think we need quotes around Package@*.swift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18