Skip to content

Testing Swift CI integration #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2024
Merged

Testing Swift CI integration #49

merged 5 commits into from
Jan 23, 2024

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal shahmishal requested a review from rauhul as a code owner December 12, 2023 16:59
@shahmishal
Copy link
Member Author

@swift-ci test

@rauhul rauhul force-pushed the shahmishal-patch-1 branch from 998e84d to 9bdaf15 Compare December 12, 2023 17:43
@shahmishal
Copy link
Member Author

@swift-ci test

1 similar comment
@rauhul
Copy link
Collaborator

rauhul commented Dec 12, 2023

@swift-ci test

@rauhul
Copy link
Collaborator

rauhul commented Dec 12, 2023 •
edited
Loading

@ahoppen is the crash (Swift main) a known macros bug?

[315/324] Compiling MMIOTests ExpansionTypeCheckTests.swift
Swift/UnsafeRawPointer.swift:421: Fatal error: load from misaligned raw pointer

*** Signal 4: Backtracing from 0x7f5cdb8d12b4... done ***

*** Program crashed: Illegal instruction at 0x00007f5cdb8d12b4 ***

Thread 0 "MMIOMacros" crashed:

0      0x00007f5cdb8d12b4 closure #1 in closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 308 in libswiftCore.so
1 [ra] 0x00007f5cdb8d1062 closure #1 in closure #1 in _assertionFailure(_:_:file:line:flags:) + 257 in libswiftCore.so
2 [ra] 0x00007f5cdb8d0f1d closure #1 in _assertionFailure(_:_:file:line:flags:) + 380 in libswiftCore.so
3 [ra] 0x00007f5cdb8d0aa6 _assertionFailure(_:_:file:line:flags:) + 229 in libswiftCore.so
4 [ra] 0x00007f5cdb8d0cfe _fatalErrorMessage(_:_:file:line:flags:) + 45 in libswiftCore.so
5 [ra] 0x00007f5cdb9a0190 UnsafeRawBufferPointer.load<A>(fromByteOffset:as:) + 191 in libswiftCore.so
6 [ra] 0x000055a82be5bec2 closure #1 in PluginHostConnection.waitForNextMessage<A>(_:) + 81 in MMIOMacros at /code/.build/checkouts/swift-syntax/Sources/SwiftCompilerPlugin/CompilerPlugin.swift:203:31
7 [ra] 0x00007f5cdaf0f6ca partial apply for closure #1 in Data.InlineData.withUnsafeBytes<A>(_:) + 25 in libFoundation.so

@ahoppen
Copy link
Contributor

ahoppen commented Dec 12, 2023

Could you try bumping the version requirement to 509.0.2? This might be swiftlang/swift-syntax#2321, which isn’t in 509.0.1.

@rauhul
Copy link
Collaborator

rauhul commented Dec 12, 2023

@swift-ci test

@rauhul rauhul force-pushed the shahmishal-patch-1 branch 2 times, most recently from 1083920 to 20d6488 Compare December 19, 2023 23:02
@rauhul rauhul force-pushed the shahmishal-patch-1 branch from 20d6488 to 3326ac8 Compare January 18, 2024 18:07
@shahmishal
Copy link
Member Author

@swift-ci test

rauhul and others added 3 commits January 22, 2024 14:13
@rauhul
Skip FileCheck tests if tool not found
db2bf40 
FileCheck is an internal LLVM tool which is hard for both Swift-CI and
contributors to install. These tests provide value, but we need to find
an alternative tool. Until then update the FileCheck tests to skip
running if the FileCheck binary cannot be found on the host system.
@shahmishal @rauhul
Update README.md
407530a
@rauhul
fix ci issues
e41ad91
@rauhul rauhul force-pushed the shahmishal-patch-1 branch from 3326ac8 to e41ad91 Compare January 22, 2024 22:16
@rauhul
Copy link
Collaborator

rauhul commented Jan 22, 2024

@swift-ci test

@rauhul
Copy link
Collaborator

rauhul commented Jan 22, 2024 •
edited
Loading

@neonichu @MaxDesiatov if you take a look at https://ci.swift.org/job/pr-swift-mmio-linux-510/8/ you can see the issue I was mentioning a while back where SPM rebuilds my entire library between calls:

build: lint
	@echo "building..."
	@swift build \
		--configuration $(CONFIGURATION) \
		--explicit-target-dependency-import-check error

test: build
	@echo "testing..."
	@swift test \
		--configuration $(CONFIGURATION) \
		--parallel \
		--explicit-target-dependency-import-check error

This seems to bloat CI time by ~8 minutes

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal
Copy link
Member Author

@swift-ci test

@rauhul rauhul merged commit a84e4f7 into main Jan 23, 2024
@rauhul rauhul deleted the shahmishal-patch-1 branch January 23, 2024 07:49
@rauhul
Copy link
Collaborator

rauhul commented Jan 23, 2024

Fixes #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauhul rauhul Awaiting requested review from rauhul rauhul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahmishal @rauhul @ahoppen