Add simple benchmarking to HttpResponsivenessServer #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaghavRoy145
force-pushed
the
benchmarking-for-http-responsiveness-server
branch
5 times, most recently
from
4bbd9df to
b9565de
Compare
RaghavRoy145
changed the title
RaghavRoy145
force-pushed
the
benchmarking-for-http-responsiveness-server
branch
from
b9565de to
7888097
Compare
Motivation
Provide optional, in‑pipeline latency logging in HTTPResponsivenessServer and a straightforward way to gather end‑to‑end percentile metrics.
Modifications
main.swift
Imported Foundation for DispatchTime.
Added PerformanceMeasurementHandler (logs “Request handled in XX ms”) and PingHandler (/ping endpoint).
Extended channelInitializer and CLI with a --collect-benchmarks flag to insert these handlers only when requested.
Examples/collect_benchmarks.sh
New Bash script that reads the server’s logs, collects a user‑specified number of samples, uses Python/NumPy to compute
p0/p25/p50/p75/p90/p99/p100, and prints a Unicode table.
Result
Users can now opt in to per‑request latency logging via --collect-benchmarks, and run a one‑step script to produce full percentile reports.
RaghavRoy145
force-pushed
the
benchmarking-for-http-responsiveness-server
branch
from
7888097 to
6b9f990
Compare
RaghavRoy145
changed the title
RaghavRoy145
force-pushed
the
benchmarking-for-http-responsiveness-server
branch
from
011b575 to
c0c257b
Compare
RaghavRoy145
force-pushed
the
benchmarking-for-http-responsiveness-server
branch
from
c0c257b to
5e59c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Provide optional, in‑pipeline latency logging in HTTPResponsivenessServer and a straightforward way to gather end‑to‑end percentile metrics, to address apple/swift-nio#2844 (comment)
Modifications
main.swift
Examples/ping-benchmarks/run_benchmarks.sh
Result
Users can now opt in to per‑request latency logging via --collect-benchmarks, and run a one‑step script to produce full percentile reports.