Skip to content

HTTP API: Add missing defaults/enums, fix mistakes #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Simran-B
Copy link
Contributor

@Simran-B Simran-B commented Jun 24, 2025

Description

TODOs:

  • If the default value depends on a startup option, should we refrain from specifying one in the OpenAPI description?
    For example, replicationFactor is 1 by default in a cluster (and ignored in single server), but this depends on the --cluster.default-replication-factor startup options for user collections and on --cluster.system-replication-factor for system collections. If the startup options aren't set, then the default is indeed 1, but otherwise it has the value of the respective startup option. Should we therefore omit default: 1 and describe how the default value is determined in description? --> Describe in description how the default is determined. If we do this as a separate paragraph and like Default: Controlled by the --foo.bar` startup option, then it's also quick to find.
  • POST /_api/cursor:
    • maxNumberOfPlans default? Internally 128 but controlled by --query.optimizer-max-plans
    • maxRuntime default controlled by --query.max-runtime
    • allowDirtyReads: default false? Duplicate remark from x-arango-allow-dirty-read header that it's ignored when run as part of Stream Transaction?
  • PUT /_db/{database-name}/_api/query-cache/properties: mention related startup options? (Copy from getting the cache config, or move?)
  • POST /_db/{database-name}/_api/transaction/begin: maxTransactionSize controlled by --transaction.streaming-max-transaction-size - note that this feature has been added in 3.12!

Upstream PRs

  • 3.10:
  • 3.11:
  • 3.12:
  • 3.13:

@Simran-B Simran-B self-assigned this Jun 24, 2025
Copy link
Contributor

Deploy Preview Available Via
https://deploy-preview-718--docs-hugo.netlify.app

@cla-bot cla-bot bot added the cla-signed label Jun 24, 2025
@Simran-B Simran-B changed the title HTTP API: Add some missing defaults/enums HTTP API: Add missing defaults/enums, fix mistakes Jul 16, 2025
Missing defaults, add uniqueItems property for indexes, fix type/structure mistakes, reword some descriptions

Certain endpoints like for transactions would require multiple types (string or array of strings), but we cannot render that yet
@Simran-B Simran-B requested a review from nerpaula August 4, 2025 12:18
properties:
user:
description: |
The name of the user as a string. This is mandatory.
type: string
passwd:
description: |
The user password as a string. If not specified, it will default to an empty
The user password as a string. If not specified, it default to an empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The user password as a string. If not specified, it default to an empty
The user password as a string. If not specified, it defaults to an empty

properties:
user:
description: |
The name of the user as a string. This is mandatory.
type: string
passwd:
description: |
The user password as a string. If not specified, it will default to an empty
The user password as a string. If not specified, it default to an empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The user password as a string. If not specified, it default to an empty
The user password as a string. If not specified, it defaults to an empty

@@ -267,10 +278,10 @@ paths:
type: number
users:
description: |
An array of user objects. The users will be granted *Administrate* permissions
for the new database. Users that do not exist yet will be created.
An array of user objects. The users is granted *Administrate* permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An array of user objects. The users is granted *Administrate* permissions
An array of user objects. The user is granted *Administrate* permissions

@@ -269,10 +280,10 @@ paths:
type: number
users:
description: |
An array of user objects. The users will be granted *Administrate* permissions
for the new database. Users that do not exist yet will be created.
An array of user objects. The users is granted *Administrate* permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An array of user objects. The users is granted *Administrate* permissions
An array of user objects. The user is granted *Administrate* permissions

@@ -267,10 +278,10 @@ paths:
type: number
users:
description: |
An array of user objects. The users will be granted *Administrate* permissions
for the new database. Users that do not exist yet will be created.
An array of user objects. The users is granted *Administrate* permissions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An array of user objects. The users is granted *Administrate* permissions
An array of user objects. The user is granted *Administrate* permissions

Copy link
Contributor

@nerpaula nerpaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few typos to fix, other than that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants