-
Notifications
You must be signed in to change notification settings - Fork 7
HTTP API: Add missing defaults/enums, fix mistakes #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploy Preview Available Via |
…mention startup options, add missing slowStreamingQueryThreshold option
details parameter would require polymorphic response description (array or object) but we cannot render this at the moment
Missing defaults, add uniqueItems property for indexes, fix type/structure mistakes, reword some descriptions Certain endpoints like for transactions would require multiple types (string or array of strings), but we cannot render that yet
properties: | ||
user: | ||
description: | | ||
The name of the user as a string. This is mandatory. | ||
type: string | ||
passwd: | ||
description: | | ||
The user password as a string. If not specified, it will default to an empty | ||
The user password as a string. If not specified, it default to an empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user password as a string. If not specified, it default to an empty | |
The user password as a string. If not specified, it defaults to an empty |
properties: | ||
user: | ||
description: | | ||
The name of the user as a string. This is mandatory. | ||
type: string | ||
passwd: | ||
description: | | ||
The user password as a string. If not specified, it will default to an empty | ||
The user password as a string. If not specified, it default to an empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user password as a string. If not specified, it default to an empty | |
The user password as a string. If not specified, it defaults to an empty |
@@ -267,10 +278,10 @@ paths: | |||
type: number | |||
users: | |||
description: | | |||
An array of user objects. The users will be granted *Administrate* permissions | |||
for the new database. Users that do not exist yet will be created. | |||
An array of user objects. The users is granted *Administrate* permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An array of user objects. The users is granted *Administrate* permissions | |
An array of user objects. The user is granted *Administrate* permissions |
@@ -269,10 +280,10 @@ paths: | |||
type: number | |||
users: | |||
description: | | |||
An array of user objects. The users will be granted *Administrate* permissions | |||
for the new database. Users that do not exist yet will be created. | |||
An array of user objects. The users is granted *Administrate* permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An array of user objects. The users is granted *Administrate* permissions | |
An array of user objects. The user is granted *Administrate* permissions |
@@ -267,10 +278,10 @@ paths: | |||
type: number | |||
users: | |||
description: | | |||
An array of user objects. The users will be granted *Administrate* permissions | |||
for the new database. Users that do not exist yet will be created. | |||
An array of user objects. The users is granted *Administrate* permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An array of user objects. The users is granted *Administrate* permissions | |
An array of user objects. The user is granted *Administrate* permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few typos to fix, other than that LGTM
Description
TODOs:
For example,
replicationFactor
is1
by default in a cluster (and ignored in single server), but this depends on the--cluster.default-replication-factor
startup options for user collections and on--cluster.system-replication-factor
for system collections. If the startup options aren't set, then the default is indeed1
, but otherwise it has the value of the respective startup option. Should we therefore omitdefault: 1
and describe how the default value is determined indescription
? --> Describe in description how the default is determined. If we do this as a separate paragraph and likeDefault: Controlled by the
--foo.bar` startup option, then it's also quick to find.POST /_api/cursor
:--query.optimizer-max-plans
--query.max-runtime
PUT /_db/{database-name}/_api/query-cache/properties
: mention related startup options? (Copy from getting the cache config, or move?)POST /_db/{database-name}/_api/transaction/begin
: maxTransactionSize controlled by--transaction.streaming-max-transaction-size
- note that this feature has been added in 3.12!Upstream PRs