Fix getTime() timezone

[pennam]

with this changes we ansure getTime is always using UTC timezone and we can check NTP is synced comparing output with UNIX epoch.

[github-actions]

Memory usage change @ 3b31d79

Board	flash	%	RAM for global variables	%
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A
arduino:renesas_portenta:portenta_c33	🔺 +360 - +456	+0.02 - +0.02	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/HTTPClient flash	%	examples/HTTPClient RAM for global variables	%	examples/HTTPSClient flash	%	examples/HTTPSClient RAM for global variables	%	examples/GetTime flash	%	examples/GetTime RAM for global variables	%	examples/GetLocation flash	%	examples/GetLocation RAM for global variables	%	examples/DeleteSMS flash	%	examples/DeleteSMS RAM for global variables	%	examples/ReceiveSMS flash	%	examples/ReceiveSMS RAM for global variables	%	examples/SendSMS flash	%	examples/SendSMS RAM for global variables	%	examples/ModemTerminal flash	%	examples/ModemTerminal RAM for global variables	%
arduino:mbed_portenta:envie_m7	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A
arduino:renesas_portenta:portenta_c33	400	0.02	0	0.0	400	0.02	0	0.0	456	0.02	0	0.0	456	0.02	0	0.0	360	0.02	0	0.0	360	0.02	0	0.0	376	0.02	0	0.0	424	0.02	0	0.0

Click for full report CSV

Board,examples/HTTPClient<br>flash,%,examples/HTTPClient<br>RAM for global variables,%,examples/HTTPSClient<br>flash,%,examples/HTTPSClient<br>RAM for global variables,%,examples/GetTime<br>flash,%,examples/GetTime<br>RAM for global variables,%,examples/GetLocation<br>flash,%,examples/GetLocation<br>RAM for global variables,%,examples/DeleteSMS<br>flash,%,examples/DeleteSMS<br>RAM for global variables,%,examples/ReceiveSMS<br>flash,%,examples/ReceiveSMS<br>RAM for global variables,%,examples/SendSMS<br>flash,%,examples/SendSMS<br>RAM for global variables,%,examples/ModemTerminal<br>flash,%,examples/ModemTerminal<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,400,0.02,0,0.0,400,0.02,0,0.0,456,0.02,0,0.0,456,0.02,0,0.0,360,0.02,0,0.0,360,0.02,0,0.0,376,0.02,0,0.0,424,0.02,0,0.0

[sebromero]

Looks good but please add a comment here and mention that this function will try to sync with an NTP server to get the current time.

[sebromero]

@pennam Actually this is already implemented in the function getCellularTime. Can we use that one instead?

[sebromero]

@pennam We would need to change getNetworkTime to getNetworkUTCTime inside getCellularTime. Not sure this has any side effects.

[pennam]

getTime() is a private static function of the library, used to feed BearSSLClient as callback, it have to return time in UTC format and it cannot be called as cellular.getTime() and we cannot feed BearSSLClient with getCellularTime()

To keep backward compatibility I've added a flag to getCellularTime() adding the possibility for the user the get localtime or utc time 4b7a446

I'm splitting PR #29 to reduce the scope and make it more simple to review

[pennam]

To avoid duplication of NTPSync code we can add a private static method that only takes care of the NTPsync call and is called by both getTime() and getCellularTime().

[pennam]

@sebromero please take a look at #32 🙂