-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Labels
conclusion: declinedWill not be worked onWill not be worked ontopic: documentationRelated to documentation for the projectRelated to documentation for the projecttype: enhancementProposed improvementProposed improvement
Description
As highlighted by @leonardocavagnis in #22:
Cannot port squarelinestudio_lvgl to v9 because SquareLine Studio is no longer compatible with LVGL. It works only with v8 and earlier.
The squarelinestudio_lvgl_v8.ino is no longer relevant and should be adapted/deleted since:
- It is not part of the examples we want our Users to interact with
- The code is not expected to compile (and is not included as part of the
compile-example.yml
workflow)Arduino_GigaDisplay/.github/workflows/compile-examples.yml
Lines 30 to 50 in de47486
env: UNIVERSAL_SKETCH_PATHS: | - examples/backlight/SimpleBacklight - examples/basic/ArduinoLogoDrawing - examples/basic/SimpleText - examples/camera/display_camera - examples/gfx/geometrical-shapes - examples/gfx/hello-world - examples/gfx/touch-switch - examples/imu/accelerometer - examples/imu/gyroscope - examples/lvgl/bar_lvgl - examples/lvgl/button_lvgl - examples/lvgl/check_radio_lvgl - examples/lvgl/image_lvgl - examples/lvgl/imu_orientation - examples/lvgl/slider_lvgl - examples/microphone/PDMSerialPlotter - examples/rgb/SimpleRGB - examples/rgb/blink
Possible solutions
Option | Positive | Negative |
---|---|---|
Remove | Quick and easy fix, reduced future maintenance. No Zendesk tickets mentioning this specific example, so should have minimal affect on Users | Library functionality scope reduced |
Adapt | Retain compatibility with SquareLine Studio | Additional effort for a discontinued feature |
Metadata
Metadata
Assignees
Labels
conclusion: declinedWill not be worked onWill not be worked ontopic: documentationRelated to documentation for the projectRelated to documentation for the projecttype: enhancementProposed improvementProposed improvement