-
Notifications
You must be signed in to change notification settings - Fork 0
Change reconfigure pin for nicla vision #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 7 7
Lines 720 720
Branches 86 86
=======================================
Hits 650 650
Misses 70 70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Memory usage change @ 49f96f8
Click for full report table
Click for full report CSV
|
@@ -97,7 +97,7 @@ | |||
|
|||
#if defined(ARDUINO_NICLA_VISION) | |||
#define NETWORK_CONFIGURATOR_COMPATIBLE 1 | |||
#define PIN_RECONFIGURE 2 | |||
#define PIN_RECONFIGURE 39 // PA_13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to call it A1
as in the documentation (pin numbers are unstable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The analog pins are not working, we found the pin PA_13 that works. For using a label we should have used a translation function that usually we don't have, so we have prefered put the pin number with the label in the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested A0 yesterday and it was working on a basic sketch, let me check with the full thing. Moreover, PA13=SWD is not a real pin but a "fin" between pins, so I strongly recommend NOT to use it for any reason except during manufacturing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sketch works as intended, with a button connected to A0 (the uppermost pin, close to the reset button and the LED)
int i = 0;
void _pressedCallback() {
digitalWrite(LED_BUILTIN, i % 2 == 0 ? LOW : HIGH);
i++;
}
// the setup function runs once when you press reset or power the board
void setup() {
pinMode(A0, INPUT_PULLUP);
pinMode(LED_BUILTIN, OUTPUT);
attachInterrupt(A0, _pressedCallback, CHANGE);
digitalWrite(LED_BUILTIN, HIGH);
Serial.begin(115200);
}
// the loop function runs over and over again forever
void loop() {
delay(1000);
Serial.println(i);
}
Change the reconfiguration pin of Nicla vision from pin
D2
to pinPA_13 (39)