Robot_Control, Robot_Motor, WiFi libraries incorrect include statement

[allgood38]

arduino/libraries/Robot_Control/

./Squawk.h:10:#include "Arduino.h"
./Multiplexer.h:5:#include "Arduino.h"
./Adafruit_GFX.h:20: #include "Arduino.h"
./Arduino_LCD.h:23: #include "Arduino.h"
./EasyTransfer2.h:33:#include "Arduino.h"
./utility/twi.c:28:#include "Arduino.h" // for digitalWrite
./EEPROM_I2C.h:5:#include "Arduino.h"
./keyboard.cpp:4:#include "Arduino.h"
./Compass.h:5:#include "Arduino.h"
./EEPROM_I2C.cpp:5:#include "Arduino.h"
./ArduinoRobot.h:14:#include "Arduino.h"

Normally libraries include the Arduino.h file with #include <Arduino.h>.

Although this does not appear to create a compilation error in the Ardiuno IDE, it does go against the convention followed by other libraries and does create compilation errors (circular dependancies) in other build programs such as inotool.

[cmaglie]

I've found much more libraries that uses the include with quotes:

Audio/src/Audio.h:#include "Arduino.h"
Audio/arch/sam/DAC.h:#include "Arduino.h"
EEPROM/arch/avr/EEPROM.cpp:#include "Arduino.h"
Ethernet/src/Dhcp.cpp:#include "Arduino.h"
Ethernet/src/Dns.cpp:#include "Arduino.h"
Ethernet/src/EthernetClient.cpp:#include "Arduino.h"
Ethernet/src/EthernetClient.h:#include "Arduino.h"
Firmata/src/Boards.h:#include "Arduino.h"       // for digitalRead, digitalWrite, etc
LiquidCrystal/src/LiquidCrystal.cpp:#include "Arduino.h"
Robot_Control/src/ArduinoRobot.h:#include "Arduino.h"
Robot_Control/arch/avr/keyboard.cpp:#include "Arduino.h"
Robot_Control/arch/avr/Compass.h:#include "Arduino.h"
Robot_Control/arch/avr/Multiplexer.h:#include "Arduino.h"
Robot_Control/arch/avr/EEPROM_I2C.h:#include "Arduino.h"
Robot_Control/arch/avr/EEPROM_I2C.cpp:#include "Arduino.h"
Robot_Control/arch/avr/utility/twi.c:#include "Arduino.h" // for digitalWrite
Robot_Control/arch/avr/utility/Adafruit_GFX.h: #include "Arduino.h"
Robot_Control/arch/avr/Arduino_LCD.h: #include "Arduino.h"
Robot_Control/arch/avr/Squawk.h:#include "Arduino.h"
Robot_Control/arch/avr/EasyTransfer2.h:#include "Arduino.h"
Robot_Motor/src/Multiplexer.h:#include "Arduino.h"
Robot_Motor/src/LineFollow.h:   #include "Arduino.h"
Robot_Motor/src/ArduinoRobotMotorBoard.h:#include "Arduino.h"
Robot_Motor/src/EasyTransfer2.h:#include "Arduino.h"
SpacebrewYun/src/SpacebrewYun.h:#include "Arduino.h"
Stepper/src/Stepper.cpp:#include "Arduino.h"
TFT/src/TFT.h:#include "Arduino.h"
TFT/src/utility/Adafruit_ST7735.h: #include "Arduino.h"
TFT/src/utility/Adafruit_GFX.h: #include "Arduino.h"
USBHost/src/Usb.cpp:#include "Arduino.h"
USBHost/src/adk.h:#include "Arduino.h"
USBHost/src/hid.h:#include "Arduino.h"
USBHost/src/parsetools.h:#include "Arduino.h"
USBHost/src/hidboot.h:#include "Arduino.h"
WiFi/src/WiFiClient.h:#include "Arduino.h"
WiFi/src/utility/wifi_drv.cpp:#include "Arduino.h"
WiFi/src/utility/server_drv.cpp:#include "Arduino.h"
WiFi/arch/sam/utility/spi_drv.cpp:#include "Arduino.h"
WiFi/arch/avr/utility/spi_drv.cpp:#include "Arduino.h"

The error you're experiencing happens only for the Robot library, or for all the other too?

C

[allgood38]

I'm unable to reproduce the bug I was experiencing, so I guess it doesn't matter. Thanks for searching through the files though.

Why are quotes being used when the Arduino.h isn't in the same local directory?

[cmaglie]

IMHO there isn't a reason, just the original authors randomly used quotes instead of brackets without caring too much.

C