Skip to content

Proceed with upload even if port can't be found. #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2014

Conversation

damellis
Copy link
Contributor

This is a quick / partial fix for issue #1791: an inability to upload without an explicit port (e.g. for the AVRISP mkII or USBtinyISP). Currently, it simply allows the upload to proceed if the port can't be found, leaving the error (if any) to occur later. We probably also need to do a better job of catching that errors that do occur and showing better error messages for them. (It probably doesn't make sense to try to preemptively check for the existence of the port, since the logic that determines whether or not a port is required for upload is rather complicated and internal to the SerialUploader class.)

Cristian, do you think it's okay to merge this as is to start? Or does better error handling need to be included first? Or any other thoughts / suggestions?

@damellis
Copy link
Contributor Author

The second commit makes error messages appear in the editor message bar. The particular messages could probably use improvement, though, in Uploader.java.

@cmaglie thoughts?

@matthijskooijman
Copy link
Collaborator

Commits look good to me.

cmaglie added a commit that referenced this pull request Jun 13, 2014
Proceed with upload even if port can't be found.
@cmaglie cmaglie merged commit 65a4b40 into arduino:ide-1.5.x Jun 13, 2014
@cmaglie
Copy link
Member

cmaglie commented Jun 13, 2014

Yeah, a better error handling is desirable, but this patch looks a good compromise for now.
Thanks!

C

@matthijskooijman
Copy link
Collaborator

For future improvements, some user ran into this problem using the USBASPloader. So this problem is not limited to the upload using programmer option, it can occur with regular uploads too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants