Proceed with upload even if port can't be found. #2126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick / partial fix for issue #1791: an inability to upload without an explicit port (e.g. for the AVRISP mkII or USBtinyISP). Currently, it simply allows the upload to proceed if the port can't be found, leaving the error (if any) to occur later. We probably also need to do a better job of catching that errors that do occur and showing better error messages for them. (It probably doesn't make sense to try to preemptively check for the existence of the port, since the logic that determines whether or not a port is required for upload is rather complicated and internal to the SerialUploader class.)
Cristian, do you think it's okay to merge this as is to start? Or does better error handling need to be included first? Or any other thoughts / suggestions?