Skip to content

JIRA-560 I2C Bus Scan #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2016
Merged

JIRA-560 I2C Bus Scan #198

merged 1 commit into from
Jun 7, 2016

Conversation

xieqi
Copy link
Contributor

@xieqi xieqi commented May 27, 2016

@linrjing @sgbihu
using read instead of write to avoid sending the extra byte when scaning I2C bus

@SidLeung
Copy link
Contributor

SidLeung commented Jun 1, 2016

Qi indicated that the library, libarc32drv_arduino101.a, which contains these files, ss_dw_i2c.c and ss_i2c_iface.c, needs to be compiled manually.

@SidLeung
Copy link
Contributor

SidLeung commented Jun 1, 2016

Instruction from Brian to manually compile the library in your local directory:

  1. Add the toolchain folder to your PATH
    export PATH=~/.arduino15/packages/intel/tools/arc-elf32/1.6.4+1.0/bin:$PATH
  2. cd system/libarc32_arduino101/
  3. make clean
  4. make
  5. mv libarc32drv_arduino101.a ../../variants/arduino_101/

@bbaltz505
Copy link
Contributor

Sorry, the toolchain path is actually out of date for Bellatrix. We should build using the 1.0.1 toolchain now. You can download the toolchain from here, extract it and add to to your path.
https://downloadmirror.intel.com/25470/eng/arc-toolchain-linux64-arcem-1.0.1.tar.bz2

@bigdinotech
Copy link
Contributor

@SidLeung @xieqi
I've tried compiling libarc32drv_arduino101.a on my initial test but maybe I did not do it correctly.
Anyway, libarc32drv_arduino101.a should be commited together with the other i2c changes

@SidLeung
Copy link
Contributor

SidLeung commented Jun 1, 2016

That is precisely the words I was looking for... Is there a way to flag it here, in gitHub, that the system library needs recompiling? Or should the developer build the library binary image and push it to the repo together with the pull request? I prefer Jerkins to build the library to eliminate any make environment differences that may exist in a developer's station. @bbaltz505 @bigdinotech @xieqi @calvinatintel

@xieqi
Copy link
Contributor Author

xieqi commented Jun 2, 2016

@SidLeung @bbaltz505 @bigdinotech @calvinatintel
agree, there should be a flag, I checked the commit history, only three commit update this library, so I didn't include the library in this commit.

@xieqi
Copy link
Contributor Author

xieqi commented Jun 6, 2016

@SidLeung @bbaltz505 @bigdinotech @calvinatintel
update the code, print the return value in serial monitor to help debug the issue, please review it, thanks.

@bigdinotech
Copy link
Contributor

@xieqi works well now.
Can you remove the debug print. After that it should be good for merge. @calvinatintel
@SidLeung

using read instead of write to avoid sending the extra byte when scaning I2C bus
@xieqi
Copy link
Contributor Author

xieqi commented Jun 7, 2016

@SidLeung @bigdinotech @calvinatintel
removed the debug print

@bigdinotech
Copy link
Contributor

@calvinatintel looks good. Please merge

@calvinatintel calvinatintel merged commit c27462c into arduino:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants